Merge branch '205682-feature-flag-removal' into 'master'

Remove the `nuget_package_registry` feature flag

See merge request gitlab-org/gitlab!25685

ee/lib/api/nuget_packages.rb

@@ -91,7 +91,6 @@ module API
     end
     resource :projects, requirements: API::NAMESPACE_OR_PROJECT_REQUIREMENTS do
       before do
-        not_found! if Feature.disabled?(:nuget_package_registry, authorized_user_project, default_enabled: true)
         authorize_packages_feature!(authorized_user_project)
       end
 

ee/spec/requests/api/nuget_packages_spec.rb

@@ -19,11 +19,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -67,9 +62,6 @@ describe API::NugetPackages do
       it_behaves_like 'rejects nuget access with invalid project id'
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -86,11 +78,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -133,9 +120,6 @@ describe API::NugetPackages do
       it_behaves_like 'rejects nuget access with invalid project id'
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -162,11 +146,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -209,9 +188,6 @@ describe API::NugetPackages do
       it_behaves_like 'rejects nuget access with invalid project id'
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -227,11 +203,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -275,9 +246,6 @@ describe API::NugetPackages do
       end
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -293,11 +261,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -343,9 +306,6 @@ describe API::NugetPackages do
       end
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -361,11 +321,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -409,9 +364,6 @@ describe API::NugetPackages do
       it_behaves_like 'rejects nuget access with invalid project id'
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -428,11 +380,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -476,9 +423,6 @@ describe API::NugetPackages do
       it_behaves_like 'rejects nuget access with invalid project id'
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 
@@ -502,11 +446,6 @@ describe API::NugetPackages do
         stub_licensed_features(packages: true)
       end
 
-      context 'with feature flag enabled' do
-        before do
-          stub_feature_flags(nuget_package_registry: { enabled: true, thing: project })
-        end
-
       context 'with valid project' do
         using RSpec::Parameterized::TableSyntax
 
@@ -550,9 +489,6 @@ describe API::NugetPackages do
       it_behaves_like 'rejects nuget access with invalid project id'
     end
 
-      it_behaves_like 'rejects nuget packages access with feature flag disabled'
-    end
-
     it_behaves_like 'rejects nuget packages access with packages features disabled'
   end
 end

ee/spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb

@@ -28,16 +28,6 @@ RSpec.shared_examples 'rejects nuget packages access with packages features disa
   end
 end
 
-RSpec.shared_examples 'rejects nuget packages access with feature flag disabled' do
-  context 'with feature flag disabled' do
-    before do
-      stub_feature_flags(nuget_package_registry: { enabled: false, thing: project })
-    end
-
-    it_behaves_like 'rejects nuget packages access', :anonymous, :not_found
-  end
-end
-
 RSpec.shared_examples 'process nuget service index request' do |user_type, status, add_member = true|
   context "for user type #{user_type}" do
     before do