Merge branch 'remove-label-by-ids' into 'master'

Remove Label.by_ids method

See merge request gitlab-org/gitlab!36800

app/models/concerns/analytics/cycle_analytics/stage.rb

@@ -125,7 +125,7 @@ module Analytics
       def label_available_for_group?(label_id)
         LabelsFinder.new(nil, { group_id: group.id, include_ancestor_groups: true, only_group_labels: true })
           .execute(skip_authorization: true)
-          .by_ids(label_id)
+          .id_in(label_id)
           .exists?
       end
     end

app/models/label.rb

@@ -149,10 +149,6 @@ class Label < ApplicationRecord
     1
   end
 
-  def self.by_ids(ids)
-    where(id: ids)
-  end
-
   def self.on_project_board?(project_id, label_id)
     return false if label_id.blank?
 

app/services/labels/available_labels_service.rb

@@ -34,7 +34,7 @@ module Labels
       return [] if ids.empty?
 
       # rubocop:disable CodeReuse/ActiveRecord
-      existing_ids = available_labels.by_ids(ids).pluck(:id)
+      existing_ids = available_labels.id_in(ids).pluck(:id)
       # rubocop:enable CodeReuse/ActiveRecord
       ids.map(&:to_i) & existing_ids
     end