Merge branch 'ajk-alert-management-n-plus-ones' into 'master'

Improve GraphQL performance specs for alert management

See merge request gitlab-org/gitlab!50459

spec/requests/api/graphql/project/alert_management/alert/assignees_spec.rb

@@ -60,19 +60,35 @@ RSpec.describe 'getting Alert Management Alert Assignees' do
     expect(second_assignees).to be_empty
   end
 
-  it 'avoids N+1 queries' do
-    base_count = ActiveRecord::QueryRecorder.new do
-      post_graphql(query, current_user: current_user)
+  describe 'performance' do
+    let(:first_n) { var('Int') }
+    let(:params) { { first: first_n } }
+    let(:limited_query) { with_signature([first_n], query) }
+
+    before do
+      create(:alert_management_alert, project: project, assignees: [current_user])
     end
 
-    # An N+1 would mean a new alert would increase the query count
-    third_alert = create(:alert_management_alert, project: project, assignees: [current_user])
+    it 'can limit results' do
+      post_graphql(limited_query, current_user: current_user, variables: first_n.with(1))
 
-    expect { post_graphql(query, current_user: current_user) }.not_to exceed_query_limit(base_count)
+      expect(alerts.size).to eq 1
+      expect(alerts).not_to include(a_hash_including('iid' => first_alert.iid.to_s))
+    end
 
-    third_assignees = assignees[third_alert.iid.to_s]
+    it 'can include all results' do
+      post_graphql(limited_query, current_user: current_user)
 
-    expect(third_assignees.length).to eq(1)
-    expect(third_assignees.first).to include('username' => current_user.username)
+      expect(alerts.size).to be > 1
+      expect(alerts).to include(a_hash_including('iid' => first_alert.iid.to_s))
+    end
+
+    it 'avoids N+1 queries' do
+      base_count = ActiveRecord::QueryRecorder.new do
+        post_graphql(limited_query, current_user: current_user, variables: first_n.with(1))
+      end
+
+      expect { post_graphql(limited_query, current_user: current_user) }.not_to exceed_query_limit(base_count)
+    end
   end
 end

spec/requests/api/graphql/project/alert_management/alert/notes_spec.rb

@@ -65,16 +65,28 @@ RSpec.describe 'getting Alert Management Alert Notes' do
     expect(second_notes_result).to be_empty
   end
 
-  it 'avoids N+1 queries' do
-    base_count = ActiveRecord::QueryRecorder.new do
-      post_graphql(query, current_user: current_user)
-    end
+  describe 'performance' do
+    let(:first_n) { var('Int') }
+    let(:params) { { first: first_n } }
 
+    before do
       # An N+1 would mean a new alert would increase the query count
       create(:alert_management_alert, project: project)
+    end
 
-    expect { post_graphql(query, current_user: current_user) }.not_to exceed_query_limit(base_count)
+    it 'avoids N+1 queries' do
+      q = with_signature([first_n], query)
+
+      base_count = ActiveRecord::QueryRecorder.new do
+        post_graphql(q, current_user: current_user, variables: first_n.with(1))
+        expect(alerts_result.length).to eq(1)
+      end
+
+      expect do
+        post_graphql(q, current_user: current_user, variables: first_n.with(3))
         expect(alerts_result.length).to eq(3)
+      end.not_to exceed_query_limit(base_count)
+    end
   end
 
   context 'for non-system notes' do