Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
5b89d248
Commit
5b89d248
authored
Dec 09, 2020
by
Savas Vedova
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix console errors when changing filter
parent
cc0bc406
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
1 deletion
+14
-1
ee/app/assets/javascripts/vulnerabilities/components/remediated_badge.vue
...vascripts/vulnerabilities/components/remediated_badge.vue
+14
-1
No files found.
ee/app/assets/javascripts/vulnerabilities/components/remediated_badge.vue
View file @
5b89d248
...
...
@@ -7,6 +7,19 @@ export default {
GlPopover
,
GlBadge
,
},
methods
:
{
/**
* BVPopover retrieves the target during the `beforeDestroy` hook to deregister attached
* events. Since during `beforeDestroy` refs are `undefined`, it throws a warning in the
* console because we're trying to access the `$el` property of `undefined`. Optional
* chaining is not working in templates, which is why the computed property is used.
*
* See more on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49628#note_464803276
*/
target
()
{
return
this
.
$refs
.
badge
?.
$el
;
},
},
};
</
script
>
...
...
@@ -22,7 +35,7 @@ export default {
'The vulnerability is no longer detected. Verify the vulnerability has been fixed or removed before changing its status.',
)
"
:target=
"
() => $refs.badge.$el
"
:target=
"
target
"
:title=
"__('Vulnerability remediated. Review before resolving.')"
placement=
"top"
triggers=
"hover focus"
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment