Merge branch 'remove-ff-create_vulnerabilities_via_api' into 'master'

Remove feature flag `create_vulnerabilities_via_api`

See merge request gitlab-org/gitlab!75685

config/feature_flags/development/create_vulnerabilities_via_api.yml

----
-name: create_vulnerabilities_via_api
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68158
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/338694
-milestone: '14.3'
-type: development
-group: group::threat insights
-default_enabled: true

ee/app/graphql/mutations/vulnerabilities/create.rb

@@ -73,8 +73,6 @@ module Mutations
       def resolve(**attributes)
         project = authorized_find!(id: attributes.fetch(:project))
 
-        raise Gitlab::Graphql::Errors::ResourceNotAvailable, 'Feature disabled' unless Feature.enabled?(:create_vulnerabilities_via_api, project, default_enabled: :yaml)
-
         params = build_vulnerability_params(attributes)
 
         result = ::Vulnerabilities::ManuallyCreateService.new(

ee/app/services/vulnerabilities/manually_create_service.rb

@@ -17,10 +17,6 @@ module Vulnerabilities
     end
 
     def execute
-      unless Feature.enabled?(:create_vulnerabilities_via_api, @project, default_enabled: :yaml)
-        return ServiceResponse.error(message: "create_vulnerabilities_via_api feature flag is not enabled for this project")
-      end
-
       raise Gitlab::Access::AccessDeniedError unless authorized?
 
       timestamps_dont_match_state_message = match_state_fields_with_state

ee/spec/graphql/mutations/vulnerabilities/create_spec.rb

@@ -77,21 +77,6 @@ RSpec.describe Mutations::Vulnerabilities::Create do
 
       let(:project_gid) { GitlabSchema.id_from_object(project) }
 
-      context 'when feature flag is disabled' do
-        before do
-          stub_feature_flags(create_vulnerabilities_via_api: false)
-        end
-
-        it 'raises an error' do
-          expect { subject }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable)
-        end
-      end
-
-      context 'when feature flag is enabled' do
-        before do
-          stub_feature_flags(create_vulnerabilities_via_api: project)
-        end
-
       it 'returns the created vulnerability' do
         expect(mutated_vulnerability).to be_detected
         expect(mutated_vulnerability.description).to eq(attributes.dig(:description))
@@ -152,5 +137,4 @@ RSpec.describe Mutations::Vulnerabilities::Create do
       end
     end
   end
-  end
 end

ee/spec/services/vulnerabilities/manually_create_service_spec.rb

@@ -18,60 +18,6 @@ RSpec.describe Vulnerabilities::ManuallyCreateService do
       project.add_developer(user)
     end
 
-    context 'when feature flag is disabled' do
-      before do
-        stub_feature_flags(create_vulnerabilities_via_api: false)
-      end
-
-      let(:scanner_attributes) do
-        {
-          id: "my-custom-scanner",
-          name: "My Custom Scanner",
-          url: "https://superscanner.com",
-          vendor: vendor_attributes,
-          version: "21.37.00"
-        }
-      end
-
-      let(:vendor_attributes) do
-        {
-          name: "Custom Scanner Vendor"
-        }
-      end
-
-      let(:identifier_attributes) do
-        {
-          name: "Test identifier 1",
-          url: "https://test.com"
-        }
-      end
-
-      let(:params) do
-        {
-          vulnerability: {
-            name: "Test vulnerability",
-            state: "detected",
-            severity: "unknown",
-            confidence: "unknown",
-            identifiers: [identifier_attributes],
-            scanner: scanner_attributes,
-            solution: "rm -rf --no-preserve-root /"
-          }
-        }
-      end
-
-      it 'returns an error' do
-        result = subject
-        expect(result.success?).to be_falsey
-        expect(subject.message).to match(/create_vulnerabilities_via_api feature flag is not enabled for this project/)
-      end
-    end
-
-    context 'when feature flag is enabled' do
-      before do
-        stub_feature_flags(create_vulnerabilities_via_api: project)
-      end
-
     context 'with valid parameters' do
       let(:scanner_attributes) do
         {
@@ -274,7 +220,6 @@ RSpec.describe Vulnerabilities::ManuallyCreateService do
       end
     end
   end
-  end
 
   context 'when user does not have rights to dismiss a vulnerability' do
     let(:params) { {} }