Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
601e58b2
Commit
601e58b2
authored
Apr 26, 2021
by
Abdul Wadood
Committed by
Dylan Griffith
Apr 26, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/support
parent
7d524985
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
4 deletions
+7
-4
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-4
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-support.yml
...eased/rspec-empty-lines-after-letitbe-ee-spec-support.yml
+5
-0
ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb
...es/graphql/geo/geo_registries_resolver_shared_examples.rb
+1
-0
ee/spec/support/shared_examples/services/search_notes_shared_examples.rb
.../shared_examples/services/search_notes_shared_examples.rb
+1
-0
No files found.
.rubocop_manual_todo.yml
View file @
601e58b2
...
@@ -527,10 +527,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
...
@@ -527,10 +527,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
-
ee/spec/services/requirements_management/update_requirement_service_spec.rb
-
ee/spec/services/requirements_management/update_requirement_service_spec.rb
-
ee/spec/services/resource_access_tokens/create_service_spec.rb
-
ee/spec/services/resource_access_tokens/create_service_spec.rb
-
ee/spec/services/resource_access_tokens/revoke_service_spec.rb
-
ee/spec/services/resource_access_tokens/revoke_service_spec.rb
-
ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb
-
ee/spec/support/shared_examples/graphql/mutations/set_multiple_assignees_shared_examples.rb
-
ee/spec/support/shared_examples/quick_actions/issue/status_page_quick_actions_shared_examples.rb
-
ee/spec/support/shared_examples/services/search_notes_shared_examples.rb
-
spec/controllers/confirmations_controller_spec.rb
-
spec/controllers/confirmations_controller_spec.rb
-
spec/controllers/dashboard/projects_controller_spec.rb
-
spec/controllers/dashboard/projects_controller_spec.rb
-
spec/controllers/invites_controller_spec.rb
-
spec/controllers/invites_controller_spec.rb
...
...
ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-support.yml
0 → 100644
View file @
601e58b2
---
title
:
Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/support
merge_request
:
58292
author
:
Abdul Wadood @abdulwd
type
:
fixed
ee/spec/support/shared_examples/graphql/geo/geo_registries_resolver_shared_examples.rb
View file @
601e58b2
...
@@ -11,6 +11,7 @@ RSpec.shared_examples_for 'a Geo registries resolver' do |registry_factory_name|
...
@@ -11,6 +11,7 @@ RSpec.shared_examples_for 'a Geo registries resolver' do |registry_factory_name|
let_it_be
(
:registry2
)
{
create
(
registry_factory_name
)
}
let_it_be
(
:registry2
)
{
create
(
registry_factory_name
)
}
let_it_be
(
:registry3
)
{
create
(
registry_factory_name
)
}
let_it_be
(
:registry3
)
{
create
(
registry_factory_name
)
}
# rubocop:enable Rails/SaveBang
# rubocop:enable Rails/SaveBang
let
(
:registries
)
{
[
registry1
,
registry2
,
registry3
]
}
let
(
:registries
)
{
[
registry1
,
registry2
,
registry3
]
}
let
(
:gql_context
)
{
{
current_user:
current_user
}
}
let
(
:gql_context
)
{
{
current_user:
current_user
}
}
...
...
ee/spec/support/shared_examples/services/search_notes_shared_examples.rb
View file @
601e58b2
...
@@ -3,6 +3,7 @@
...
@@ -3,6 +3,7 @@
RSpec
.
shared_examples
'search notes shared examples'
do
RSpec
.
shared_examples
'search notes shared examples'
do
context
'notes confidentiality'
,
:elastic
,
:sidekiq_inline
do
context
'notes confidentiality'
,
:elastic
,
:sidekiq_inline
do
let_it_be
(
:user
)
{
create
(
:user
)
}
let_it_be
(
:user
)
{
create
(
:user
)
}
let
(
:commit_id
)
{
noteable
.
is_a?
(
Commit
)
?
noteable
.
id
:
nil
}
let
(
:commit_id
)
{
noteable
.
is_a?
(
Commit
)
?
noteable
.
id
:
nil
}
let
(
:noteable_id
)
{
noteable
.
is_a?
(
Issuable
)
?
noteable
.
id
:
nil
}
let
(
:noteable_id
)
{
noteable
.
is_a?
(
Issuable
)
?
noteable
.
id
:
nil
}
let!
(
:not_confidential_note
)
{
create
(
:note
,
confidential:
false
,
noteable_id:
noteable_id
,
commit_id:
commit_id
,
noteable_type:
noteable
.
class
.
name
,
project:
noteable
.
project
,
note:
'note 1'
)
}
let!
(
:not_confidential_note
)
{
create
(
:note
,
confidential:
false
,
noteable_id:
noteable_id
,
commit_id:
commit_id
,
noteable_type:
noteable
.
class
.
name
,
project:
noteable
.
project
,
note:
'note 1'
)
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment