Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
603c008d
Commit
603c008d
authored
Jan 28, 2020
by
Scott Stern
Committed by
Mike Greiling
Jan 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix error on close of board sidebar when editing
parent
2ceaff37
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
33 additions
and
5 deletions
+33
-5
ee/app/assets/javascripts/boards/components/board_settings_sidebar.vue
.../javascripts/boards/components/board_settings_sidebar.vue
+4
-5
ee/changelogs/unreleased/197497-when-user-clicks-on-exit-while-editing-work-in-progress-limits-.yml
...clicks-on-exit-while-editing-work-in-progress-limits-.yml
+5
-0
ee/spec/features/boards/boards_spec.rb
ee/spec/features/boards/boards_spec.rb
+24
-0
No files found.
ee/app/assets/javascripts/boards/components/board_settings_sidebar.vue
View file @
603c008d
...
@@ -111,13 +111,12 @@ export default {
...
@@ -111,13 +111,12 @@ export default {
offFocus
()
{
offFocus
()
{
if
(
this
.
currentWipLimit
!==
this
.
activeList
.
maxIssueCount
)
{
if
(
this
.
currentWipLimit
!==
this
.
activeList
.
maxIssueCount
)
{
this
.
updating
=
true
;
this
.
updating
=
true
;
// NOTE: Need a ref to activeListId in case the user closes the drawer.
const
id
=
this
.
activeListId
;
this
.
updateListWipLimit
({
maxIssueCount
:
this
.
currentWipLimit
,
id
:
this
.
activeListId
})
this
.
updateListWipLimit
({
maxIssueCount
:
this
.
currentWipLimit
,
id
})
.
then
(({
config
})
=>
{
.
then
(({
config
})
=>
{
boardsStoreEE
.
setMaxIssueCountOnList
(
boardsStoreEE
.
setMaxIssueCountOnList
(
id
,
JSON
.
parse
(
config
.
data
).
list
.
max_issue_count
);
this
.
activeListId
,
JSON
.
parse
(
config
.
data
).
list
.
max_issue_count
,
);
this
.
resetStateAfterUpdate
();
this
.
resetStateAfterUpdate
();
})
})
.
catch
(()
=>
{
.
catch
(()
=>
{
...
...
ee/changelogs/unreleased/197497-when-user-clicks-on-exit-while-editing-work-in-progress-limits-.yml
0 → 100644
View file @
603c008d
---
title
:
Allow user to close sidebar while editing boardlist and save wip limit
merge_request
:
author
:
type
:
fixed
ee/spec/features/boards/boards_spec.rb
View file @
603c008d
...
@@ -225,6 +225,30 @@ describe 'issue boards', :js do
...
@@ -225,6 +225,30 @@ describe 'issue boards', :js do
end
end
end
end
context
'when the user is editing a wip limit and clicks close'
do
it
'updates the max issue count wip limit'
do
max_issue_count
=
3
page
.
within
(
find
(
'.js-board-settings-sidebar'
))
do
click_button
(
"Edit"
)
find
(
'input'
).
set
(
max_issue_count
)
end
# Off click
# Danger: coupling to gitlab-ui class name for close.
# Change when https://gitlab.com/gitlab-org/gitlab-ui/issues/578 is resolved
find
(
'.gl-drawer-close-button'
).
click
wait_for_requests
page
.
within
(
find
(
".board:nth-child(2)"
))
do
click_button
(
'List Settings'
)
end
expect
(
page
.
find
(
'.js-wip-limit'
)).
to
have_text
(
max_issue_count
)
end
end
context
"when user off clicks"
do
context
"when user off clicks"
do
it
'updates the max issue count wip limit'
do
it
'updates the max issue count wip limit'
do
max_issue_count
=
2
max_issue_count
=
2
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment