Merge branch 'remove_cluster_applications_artifact_flag' into 'master'

Remove cluster_applications_artifact feature flag

See merge request gitlab-org/gitlab!38759

app/services/clusters/parse_cluster_applications_artifact_service.rb

@@ -14,8 +14,6 @@ module Clusters
     end
 
     def execute(artifact)
-      return success unless Feature.enabled?(:cluster_applications_artifact, project)
-
       raise ArgumentError, 'Artifact is not cluster_applications file type' unless artifact&.cluster_applications?
 
       return error(too_big_error_message, :bad_request) unless artifact.file.size < MAX_ACCEPTABLE_ARTIFACT_SIZE

changelogs/unreleased/remove_cluster_applications_artifact_flag.yml

+---
+title: Enable state tracking for managed applications installed via the management project
+merge_request: 38759
+author:
+type: added

doc/user/clusters/applications.md

@@ -946,6 +946,11 @@ management project. Refer to the
 [Cilium chart](https://github.com/cilium/cilium/tree/master/install/kubernetes/cilium)
 for the available configuration options.
 
+You can check Cilium's installation status on the cluster management page:
+
+- [Project-level cluster](../project/clusters/index.md): Navigate to your project's **Operations > Kubernetes** page.
+- [Group-level cluster](../group/clusters/index.md): Navigate to your group's **Kubernetes** page.
+
 CAUTION: **Caution:**
 Installation and removal of the Cilium requires a **manual**
 [restart](https://docs.cilium.io/en/stable/gettingstarted/k8s-install-gke/#restart-unmanaged-pods)

spec/services/clusters/parse_cluster_applications_artifact_service_spec.rb

@@ -36,25 +36,6 @@ RSpec.describe Clusters::ParseClusterApplicationsArtifactService do
     let(:job) { deployment.deployable }
     let(:artifact) { create(:ci_job_artifact, :cluster_applications, job: job) }
 
-    context 'when cluster_applications_artifact feature flag is disabled' do
-      before do
-        stub_feature_flags(cluster_applications_artifact: false)
-      end
-
-      it 'does not call Gitlab::Kubernetes::Helm::Parsers::ListV2 and returns success immediately' do
-        expect(Gitlab::Kubernetes::Helm::Parsers::ListV2).not_to receive(:new)
-
-        result = described_class.new(job, user).execute(artifact)
-
-        expect(result[:status]).to eq(:success)
-      end
-    end
-
-    context 'when cluster_applications_artifact feature flag is enabled for project' do
-      before do
-        stub_feature_flags(cluster_applications_artifact: job.project)
-      end
-
     it 'calls Gitlab::Kubernetes::Helm::Parsers::ListV2' do
       expect(Gitlab::Kubernetes::Helm::Parsers::ListV2).to receive(:new).and_call_original
 
@@ -131,6 +112,10 @@ RSpec.describe Clusters::ParseClusterApplicationsArtifactService do
         end
       end
 
+      it 'does not affect unpermitted cluster applications' do
+        expect(Clusters::ParseClusterApplicationsArtifactService::RELEASE_NAMES).to contain_exactly('cilium')
+      end
+
       Clusters::ParseClusterApplicationsArtifactService::RELEASE_NAMES.each do |release_name|
         context release_name do
           include_examples 'parse cluster applications artifact', release_name
@@ -138,5 +123,4 @@ RSpec.describe Clusters::ParseClusterApplicationsArtifactService do
       end
     end
   end
-  end
 end