Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
642472c3
Commit
642472c3
authored
Feb 01, 2017
by
Bryce Johnson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Properly read approvalPending from dataset.
parent
03d5a4b3
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
2 deletions
+2
-2
app/assets/javascripts/merge_request_widget/widget_store.js.es6
...sets/javascripts/merge_request_widget/widget_store.js.es6
+1
-1
app/views/projects/merge_requests/widget/_open.html.haml
app/views/projects/merge_requests/widget/_open.html.haml
+1
-1
No files found.
app/assets/javascripts/merge_request_widget/widget_store.js.es6
View file @
642472c3
...
@@ -23,7 +23,7 @@
...
@@ -23,7 +23,7 @@
initWidgetState() {
initWidgetState() {
this.assignToData('showApprovals', false);
this.assignToData('showApprovals', false);
this.assignToData('disableAcceptance',
Boolean(this.rootEl.dataset.approvalPending)
);
this.assignToData('disableAcceptance',
this.rootEl.dataset.approvalPending === 'true'
);
}
}
initApprovals() {
initApprovals() {
...
...
app/views/projects/merge_requests/widget/_open.html.haml
View file @
642472c3
-
content_for
:page_specific_javascripts
do
-
content_for
:page_specific_javascripts
do
=
page_specific_javascript_tag
(
'merge_request_widget/widget_bundle.js'
)
=
page_specific_javascript_tag
(
'merge_request_widget/widget_bundle.js'
)
#merge-request-widget-app
.mr-state-widget
{
'data-endpoint'
=>
merge_request_path
(
@merge_request
),
'data-approval-pending'
=>
!
@merge_request
.
approved?
?
'true'
:
'false'
}
#merge-request-widget-app
.mr-state-widget
{
'data-endpoint'
=>
merge_request_path
(
@merge_request
),
'data-approval-pending'
=>
(
!
@merge_request
.
approved?
).
to_s
}
=
render
'projects/merge_requests/widget/heading'
=
render
'projects/merge_requests/widget/heading'
.mr-widget-body
.mr-widget-body
-# After conflicts are resolved, the user is redirected back to the MR page.
-# After conflicts are resolved, the user is redirected back to the MR page.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment