Merge branch 'dblessing-auth-events-cleanup' into 'master'

Cleanup audit event service attributes

See merge request gitlab-org/gitlab!42718

app/services/audit_event_service.rb

@@ -53,7 +53,6 @@ class AuditEventService
 
   private
 
-  attr_accessor :authentication_event
   attr_reader :ip_address
 
   def build_author(author)
@@ -99,11 +98,11 @@ class AuditEventService
   end
 
   def mark_as_authentication_event!
-    self.authentication_event = true
+    @authentication_event = true
   end
 
   def authentication_event?
-    authentication_event
+    @authentication_event
   end
 
   def log_security_event_to_database