Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
67eb538e
Commit
67eb538e
authored
Mar 19, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Ignore Signed-off-by in multi-line commit detection in CommitLinter
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
37d9715d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
1 deletion
+2
-1
lib/gitlab/danger/commit_linter.rb
lib/gitlab/danger/commit_linter.rb
+1
-1
spec/lib/gitlab/danger/commit_linter_spec.rb
spec/lib/gitlab/danger/commit_linter_spec.rb
+1
-0
No files found.
lib/gitlab/danger/commit_linter.rb
View file @
67eb538e
...
@@ -173,7 +173,7 @@ module Gitlab
...
@@ -173,7 +173,7 @@ module Gitlab
end
end
def
details
def
details
message_parts
[
2
]
message_parts
[
2
]
&
.
gsub
(
/^Signed-off-by.*$/
,
''
)
end
end
def
line_too_long?
(
line
)
def
line_too_long?
(
line
)
...
...
spec/lib/gitlab/danger/commit_linter_spec.rb
View file @
67eb538e
...
@@ -86,6 +86,7 @@ describe Gitlab::Danger::CommitLinter do
...
@@ -86,6 +86,7 @@ describe Gitlab::Danger::CommitLinter do
"A commit message"
|
false
"A commit message"
|
false
"A commit message
\n
"
|
false
"A commit message
\n
"
|
false
"A commit message
\n\n
"
|
false
"A commit message
\n\n
"
|
false
"A commit message
\n\n
Signed-off-by: User Name <user@name.me>"
|
false
"A commit message
\n\n
With details"
|
true
"A commit message
\n\n
With details"
|
true
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment