Commit 67eb538e authored by Rémy Coutable's avatar Rémy Coutable

Ignore Signed-off-by in multi-line commit detection in CommitLinter

Signed-off-by: default avatarRémy Coutable <remy@rymai.me>
parent 37d9715d
...@@ -173,7 +173,7 @@ module Gitlab ...@@ -173,7 +173,7 @@ module Gitlab
end end
def details def details
message_parts[2] message_parts[2]&.gsub(/^Signed-off-by.*$/, '')
end end
def line_too_long?(line) def line_too_long?(line)
......
...@@ -86,6 +86,7 @@ describe Gitlab::Danger::CommitLinter do ...@@ -86,6 +86,7 @@ describe Gitlab::Danger::CommitLinter do
"A commit message" | false "A commit message" | false
"A commit message\n" | false "A commit message\n" | false
"A commit message\n\n" | false "A commit message\n\n" | false
"A commit message\n\nSigned-off-by: User Name <user@name.me>" | false
"A commit message\n\nWith details" | true "A commit message\n\nWith details" | true
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment