Merge branch 'nicolasdular/remove-successful-signup-notice' into 'master'

Remove successful signup flash message

See merge request gitlab-org/gitlab!42512

app/controllers/registrations/experience_levels_controller.rb

@@ -12,7 +12,6 @@ module Registrations
 
       if current_user.save
         hide_advanced_issues
-        flash[:message] = I18n.t('devise.registrations.signed_up')
         redirect_to group_path(params[:namespace_path])
       else
         render :show

app/controllers/registrations_controller.rb

@@ -36,7 +36,7 @@ class RegistrationsController < Devise::RegistrationsController
     end
 
     # Devise sets a flash message on `create` for a successful signup,
-    # we want to show this message after the welcome page.
+    # which we don't want to show.
     flash[:notice] = nil
   rescue Gitlab::Access::AccessDeniedError
     redirect_to(new_user_session_path)
@@ -69,7 +69,6 @@ class RegistrationsController < Devise::RegistrationsController
 
       return redirect_to new_users_sign_up_group_path if experiment_enabled?(:onboarding_issues) && show_onboarding_issues_experiment?
 
-      set_flash_message! :notice, :signed_up
       redirect_to path_for_signed_in_user(current_user)
     else
       render :welcome

changelogs/unreleased/nicolasdular-remove-successful-signup-notice.yml

+---
+title: Remove successful signup flash message
+merge_request: 42512
+author:
+type: changed

spec/controllers/registrations/experience_levels_controller_spec.rb

@@ -59,8 +59,6 @@ RSpec.describe Registrations::ExperienceLevelsController do
       end
 
       context 'when user is successfully updated' do
-        it { is_expected.to set_flash[:message].to('Welcome! You have signed up successfully.') }
-
         context 'when no experience_level is sent' do
           before do
             user.user_preference.update_attribute(:experience_level, :novice)

spec/controllers/registrations_controller_spec.rb

@@ -493,10 +493,6 @@ RSpec.describe RegistrationsController do
       sign_in(create(:user))
     end
 
-    it 'sets flash message' do
-      subject
-
-      expect(flash[:notice]).to eq(I18n.t('devise.registrations.signed_up'))
-    end
+    it { is_expected.to redirect_to(dashboard_projects_path)}
   end
 end

spec/features/users/signup_spec.rb

@@ -419,7 +419,6 @@ RSpec.shared_examples 'Signup' do
     expect(new_user.software_developer_role?).to be_truthy
     expect(new_user.setup_for_company).to be_nil
     expect(page).to have_current_path(new_project_path)
-    expect(page).to have_content("Welcome! You have signed up successfully.")
   end
 end