Rename test case factory

spec/factories/ci/test_case.rb

@@ -16,7 +16,7 @@ FactoryBot.define do
       system_output { "Failure/Error: is_expected.to eq(300) expected: 300 got: -100" }
     end
 
-    trait :with_attachment do
+    trait :failed_with_attachment do
       status { Gitlab::Ci::Reports::TestCase::STATUS_FAILED }
       attachment { "some/path.png" }
     end

spec/lib/gitlab/ci/reports/test_case_spec.rb

@@ -62,7 +62,7 @@ describe Gitlab::Ci::Reports::TestCase do
     end
 
     context 'when attachment is present' do
-      let(:attachment_test_case) { build(:test_case, :with_attachment) }
+      let(:attachment_test_case) { build(:test_case, :failed_with_attachment) }
 
       it "initializes the attachment if present" do
         expect(attachment_test_case.attachment).to eq("some/path.png")

spec/lib/gitlab/ci/reports/test_reports_spec.rb

@@ -127,7 +127,7 @@ describe Gitlab::Ci::Reports::TestReports do
 
     context 'when test suites contain an attachment' do
       let(:test_case_succes) { build(:test_case) }
-      let(:test_case_with_attachment) { build(:test_case, :with_attachment) }
+      let(:test_case_with_attachment) { build(:test_case, :failed_with_attachment) }
 
       before do
         test_reports.get_suite('rspec').add_test_case(test_case_succes)

spec/lib/gitlab/ci/reports/test_suite_spec.rb

@@ -101,7 +101,7 @@ describe Gitlab::Ci::Reports::TestSuite do
     end
 
     context 'when test cases contain an attachment' do
-      let(:test_case_with_attachment) { build(:test_case, :with_attachment)}
+      let(:test_case_with_attachment) { build(:test_case, :failed_with_attachment)}
 
       before do
         test_suite.add_test_case(test_case_with_attachment)

spec/serializers/test_case_entity_spec.rb

@@ -38,7 +38,7 @@ describe TestCaseEntity do
       end
 
       context 'when attachment is present' do
-        let(:test_case) { build(:test_case, :with_attachment) }
+        let(:test_case) { build(:test_case, :failed_with_attachment) }
 
         it 'returns the attachment_url' do
           expect(subject).to include(:attachment_url)
@@ -60,7 +60,7 @@ describe TestCaseEntity do
       end
 
       context 'when attachment is present' do
-        let(:test_case) { build(:test_case, :with_attachment) }
+        let(:test_case) { build(:test_case, :failed_with_attachment) }
 
         it 'returns no attachment_url' do
           expect(subject).not_to include(:attachment_url)