Merge branch 'issue#325836-fix-empty-line-after-let-it-be-services-feature-flags' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/services/feature_flags

See merge request gitlab-org/gitlab!58419

.rubocop_manual_todo.yml

@@ -899,11 +899,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/services/dependency_proxy/find_or_create_manifest_service_spec.rb
     - spec/services/discussions/resolve_service_spec.rb
     - spec/services/discussions/unresolve_service_spec.rb
-    - spec/services/feature_flags/create_service_spec.rb
-    - spec/services/feature_flags/destroy_service_spec.rb
-    - spec/services/feature_flags/disable_service_spec.rb
-    - spec/services/feature_flags/enable_service_spec.rb
-    - spec/services/feature_flags/update_service_spec.rb
     - spec/services/git/branch_push_service_spec.rb
     - spec/services/import/bitbucket_server_service_spec.rb
     - spec/services/incident_management/incidents/create_service_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-services-feature-flags.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/services/feature_flags
+merge_request: 58419
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/services/feature_flags/create_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe FeatureFlags::CreateService do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
   let_it_be(:reporter) { create(:user) }
+
   let(:user) { developer }
 
   before_all do

spec/services/feature_flags/destroy_service_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe FeatureFlags::DestroyService do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
   let_it_be(:reporter) { create(:user) }
+
   let(:user) { developer }
   let!(:feature_flag) { create(:operations_feature_flag, project: project) }
 

spec/services/feature_flags/disable_service_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe FeatureFlags::DisableService do
 
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
+
   let(:params) { {} }
   let(:service) { described_class.new(project, user, params) }
 

spec/services/feature_flags/enable_service_spec.rb

@@ -7,6 +7,7 @@ RSpec.describe FeatureFlags::EnableService do
 
   let_it_be(:project) { create(:project) }
   let_it_be(:user) { create(:user) }
+
   let(:params) { {} }
   let(:service) { described_class.new(project, user, params) }
 

spec/services/feature_flags/update_service_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe FeatureFlags::UpdateService do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
   let_it_be(:reporter) { create(:user) }
+
   let(:user) { developer }
   let(:feature_flag) { create(:operations_feature_flag, project: project, active: true) }