Merge branch 'winh-dev-incoming_email-check' into 'master'

Remove outdated mail_room check

See merge request gitlab-org/gitlab-ce!32588

lib/system_check/incoming_email/foreman_configured_check.rb

-# frozen_string_literal: true
-
-module SystemCheck
-  module IncomingEmail
-    class ForemanConfiguredCheck < SystemCheck::BaseCheck
-      set_name 'Foreman configured correctly?'
-
-      def check?
-        path = Rails.root.join('Procfile')
-
-        File.exist?(path) && File.read(path) =~ /^mail_room:/
-      end
-
-      def show_error
-        try_fixing_it(
-          'Enable mail_room in your Procfile.'
-        )
-        for_more_information(
-          'doc/administration/reply_by_email.md'
-        )
-        fix_and_rerun
-      end
-    end
-  end
-end

lib/system_check/incoming_email_check.rb

@@ -14,8 +14,6 @@ module SystemCheck
         if Rails.env.production?
           checks << SystemCheck::IncomingEmail::InitdConfiguredCheck
           checks << SystemCheck::IncomingEmail::MailRoomRunningCheck
-        else
-          checks << SystemCheck::IncomingEmail::ForemanConfiguredCheck
         end
 
         SystemCheck.run('Reply by email', checks)