Merge branch 'prevent-duobling-ready-events' into 'master'

Prevent unnecessary doubling of js events on import pages and user calendar

Adding document.ready in Turbolinks make duplicating of events EVERY visit of page.
In example of user calendar it causes N+1 times ajax request every time you visit user page.

cc @vsizov

See merge request !456

CHANGELOG

@@ -42,6 +42,7 @@ v 7.10.0 (unreleased)
   - Send EmailsOnPush email when branch or tag is created or deleted.
   - Faster merge request processing for large repository
   - Prevent doubling AJAX request with each commit visit via Turbolink
+  - Prevent unnecessary doubling of js events on import pages and user calendar
 
 v 7.9.0
   - Add HipChat integration documentation (Stan Hu)

app/views/import/bitbucket/status.html.haml

@@ -42,5 +42,4 @@
           = button_tag "Import", class: "btn js-add-to-import"
 
 :coffeescript
-  $ ->
-    new ImporterStatus("#{jobs_import_bitbucket_path}", "#{import_bitbucket_path}")
+  new ImporterStatus("#{jobs_import_bitbucket_path}", "#{import_bitbucket_path}")

app/views/import/github/status.html.haml

@@ -42,5 +42,4 @@
           = button_tag "Import", class: "btn js-add-to-import"
 
 :coffeescript
-  $ ->
-    new ImporterStatus("#{jobs_import_github_path}", "#{import_github_path}")
+  new ImporterStatus("#{jobs_import_github_path}", "#{import_github_path}")

app/views/import/gitlab/status.html.haml

@@ -42,5 +42,4 @@
           = button_tag "Import", class: "btn js-add-to-import"
 
 :coffeescript
-  $ ->
-    new ImporterStatus("#{jobs_import_gitlab_path}", "#{import_gitlab_path}")
+  new ImporterStatus("#{jobs_import_gitlab_path}", "#{import_gitlab_path}")

app/views/import/gitorious/status.html.haml

@@ -42,5 +42,4 @@
           = button_tag "Import", class: "btn js-add-to-import"
 
 :coffeescript
-  $ ->
-    new ImporterStatus("#{jobs_import_gitorious_path}", "#{import_gitorious_path}")
+  new ImporterStatus("#{jobs_import_gitorious_path}", "#{import_gitorious_path}")

app/views/projects/issues/_issue_context.html.haml

@@ -43,7 +43,6 @@
           You're receiving notifications because you're subscribed to this thread.
 
 :coffeescript
-  $ ->
-    new Subscription("#{toggle_subscription_namespace_project_issue_path(@issue.project.namespace, @project, @issue)}")
+  new Subscription("#{toggle_subscription_namespace_project_issue_path(@issue.project.namespace, @project, @issue)}")
 
 

app/views/projects/merge_requests/show/_context.html.haml

@@ -45,7 +45,4 @@
           You're receiving notifications because you're subscribed to this thread.
 
 :coffeescript
-  $ ->
-    new Subscription("#{toggle_subscription_namespace_project_merge_request_path(@merge_request.project.namespace, @project, @merge_request)}")
-    
-      
+  new Subscription("#{toggle_subscription_namespace_project_merge_request_path(@merge_request.project.namespace, @project, @merge_request)}")
\ No newline at end of file

app/views/projects/new.html.haml

@@ -109,9 +109,8 @@
     %p Please wait a moment, this page will automatically refresh when ready.
 
 :coffeescript
-  $ ->
-    $('.how_to_import_link').bind 'click', (e) ->
-      e.preventDefault()
-      import_modal = $(this).next(".modal").show()
-    $('.modal-header .close').bind 'click', ->
-      $(".modal").hide()
+  $('.how_to_import_link').bind 'click', (e) ->
+    e.preventDefault()
+    import_modal = $(this).next(".modal").show()
+  $('.modal-header .close').bind 'click', ->
+    $(".modal").hide()

app/views/users/show.html.haml

@@ -47,5 +47,4 @@
     = render 'projects'
 
 :coffeescript
-  $ ->
-    $(".user-calendar").load("#{user_calendar_path}")
+  $(".user-calendar").load("#{user_calendar_path}")