Merge branch '212141-refactor_cycle_analytics_spec' into 'master'

Refactor value stream analytics feature specs

Closes #212141

See merge request gitlab-org/gitlab!41583

ee/spec/features/analytics/cycle_analytics/customizable_cycle_analytics_spec.rb

+# frozen_string_literal: true
+require 'spec_helper'
+
+RSpec.describe 'Customizable Group Value Stream Analytics', :js do
+  include DragTo
+
+  let_it_be(:group) { create(:group, name: 'CA-test-group') }
+  let_it_be(:sub_group) { create(:group, name: 'CA-sub-group', parent: group) }
+  let_it_be(:group2) { create(:group, name: 'CA-bad-test-group') }
+  let_it_be(:project) { create(:project, :repository, namespace: group, group: group, name: 'Cool fun project') }
+  let_it_be(:group_label1) { create(:group_label, group: group) }
+  let_it_be(:group_label2) { create(:group_label, group: group) }
+  let_it_be(:label) { create(:group_label, group: group2) }
+  let_it_be(:sub_group_label1) { create(:group_label, group: sub_group) }
+  let_it_be(:sub_group_label2) { create(:group_label, group: sub_group) }
+  let_it_be(:user) do
+    create(:user).tap do |u|
+      group.add_owner(u)
+      project.add_maintainer(u)
+    end
+  end
+
+  let(:milestone) { create(:milestone, project: project) }
+  let(:mr) { create_merge_request_closing_issue(user, project, issue, commit_message: "References #{issue.to_reference}") }
+  let(:pipeline) { create(:ci_empty_pipeline, status: 'created', project: project, ref: mr.source_branch, sha: mr.source_branch_sha, head_pipeline_of: mr) }
+
+  let(:stage_nav_selector) { '.stage-nav' }
+  let(:duration_stage_selector) { '.js-dropdown-stages' }
+
+  custom_stage_name = 'Cool beans'
+  custom_stage_with_labels_name = 'Cool beans - now with labels'
+  start_event_identifier = :merge_request_created
+  end_event_identifier = :merge_request_merged
+  start_label_event = :issue_label_added
+  stop_label_event = :issue_label_removed
+
+  let(:add_stage_button) { '.js-add-stage-button' }
+  let(:params) { { name: custom_stage_name, start_event_identifier: start_event_identifier, end_event_identifier: end_event_identifier } }
+  let(:first_default_stage) { page.find('.stage-nav-item-cell', text: 'Issue').ancestor('.stage-nav-item') }
+  let(:first_custom_stage) { page.find('.stage-nav-item-cell', text: custom_stage_name).ancestor('.stage-nav-item') }
+  let(:nav) { page.find(stage_nav_selector) }
+
+  def create_custom_stage(parent_group = group)
+    Analytics::CycleAnalytics::Stages::CreateService.new(parent: parent_group, params: params, current_user: user).execute
+  end
+
+  def select_group(target_group = group)
+    visit group_analytics_cycle_analytics_path(target_group)
+
+    expect(page).to have_selector '.js-stage-table' # wait_for_stages_to_load
+  end
+
+  def toggle_more_options(stage)
+    stage.hover
+
+    stage.find('.more-actions-toggle').click
+  end
+
+  def select_dropdown_option(name, value = start_event_identifier)
+    page.find("select[name='#{name}']").all('option').find { |item| item.value == value.to_s }.select_option
+  end
+
+  def select_dropdown_option_by_value(name, value, elem = 'option')
+    page.find("select[name='#{name}']").find("#{elem}[value=#{value}]").select_option
+  end
+
+  def wait_for_labels(field)
+    page.within("[name=#{field}]") do
+      find('.dropdown-toggle').click
+
+      wait_for_requests
+
+      expect(find('.dropdown-menu')).to have_selector('.dropdown-item')
+    end
+  end
+
+  def select_dropdown_label(field, index = 2)
+    page.find("[name=#{field}] .dropdown-menu").all('.dropdown-item')[index].click
+  end
+
+  def drag_from_index_to_index(from, to)
+    drag_to(selector: '.stage-nav>ul',
+            from_index: from,
+            to_index: to)
+  end
+
+  before do
+    stub_licensed_features(cycle_analytics_for_groups: true, type_of_work_analytics: true)
+
+    sign_in(user)
+  end
+
+  context 'Manual ordering' do
+    before do
+      select_group
+    end
+
+    let(:default_stage_order) { %w[Issue Plan Code Test Review Staging].freeze }
+
+    def confirm_stage_order(stages)
+      page.within('.stage-nav>ul') do
+        stages.each_with_index do |stage, index|
+          expect(find("li:nth-child(#{index + 1})")).to have_content(stage)
+        end
+      end
+    end
+
+    context 'with only default stages' do
+      it 'does not allow stages to be draggable', :js do
+        confirm_stage_order(default_stage_order)
+
+        drag_from_index_to_index(0, 1)
+
+        confirm_stage_order(default_stage_order)
+      end
+    end
+
+    context 'with at least one custom stage', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/216745' do
+      default_custom_stage_order = %w[Issue Plan Code Test Review Staging Cool\ beans].freeze
+      stages_near_middle_swapped = %w[Issue Plan Test Code Review Staging Cool\ beans].freeze
+      stage_dragged_to_top = %w[Review Issue Plan Code Test Staging Cool\ beans].freeze
+      stage_dragged_to_bottom = %w[Issue Plan Code Test Staging Cool\ beans Review].freeze
+
+      shared_examples 'draggable stage' do |original_order, updated_order, start_index, end_index,|
+        before do
+          page.driver.browser.manage.window.resize_to(1650, 1150)
+
+          create_custom_stage
+          select_group
+        end
+
+        it 'allows a stage to be dragged' do
+          confirm_stage_order(original_order)
+
+          drag_from_index_to_index(start_index, end_index)
+
+          confirm_stage_order(updated_order)
+        end
+
+        it 'persists the order when a group is selected' do
+          drag_from_index_to_index(start_index, end_index)
+
+          select_group
+
+          confirm_stage_order(updated_order)
+        end
+      end
+
+      context 'dragging a stage to the top', :js do
+        it_behaves_like 'draggable stage', default_custom_stage_order, stage_dragged_to_top, 4, 0
+      end
+
+      context 'dragging a stage to the bottom', :js do
+        it_behaves_like 'draggable stage', default_custom_stage_order, stage_dragged_to_bottom, 4, 7
+      end
+
+      context 'dragging stages in the middle', :js do
+        it_behaves_like 'draggable stage', default_custom_stage_order, stages_near_middle_swapped, 2, 3
+      end
+    end
+  end
+
+  context 'Add a stage button' do
+    before do
+      select_group
+    end
+
+    it 'displays the custom stage form when clicked' do
+      expect(page).not_to have_text(s_('CustomCycleAnalytics|New stage'))
+
+      expect(page).to have_selector(add_stage_button, visible: true)
+      expect(page).to have_text(s_('CustomCycleAnalytics|Add a stage'))
+      expect(page).not_to have_selector("#{add_stage_button}.active")
+
+      page.find(add_stage_button).click
+
+      expect(page).to have_selector("#{add_stage_button}.active")
+      expect(page).to have_text(s_('CustomCycleAnalytics|New stage'))
+    end
+  end
+
+  shared_examples 'submits custom stage form successfully' do |stage_name|
+    it 'custom stage is saved with confirmation message' do
+      fill_in 'custom-stage-name', with: stage_name
+      click_button(s_('CustomCycleAnalytics|Add stage'))
+
+      expect(page.find('.flash-notice')).to have_text(_("Your custom stage '%{title}' was created") % { title: stage_name })
+      expect(page).to have_selector('.stage-nav-item', text: stage_name)
+    end
+  end
+
+  shared_examples 'can create custom stages' do
+    context 'Custom stage form' do
+      let(:show_form_add_stage_button) { '.js-add-stage-button' }
+
+      before do
+        page.find(show_form_add_stage_button).click
+        wait_for_requests
+      end
+
+      context 'with empty fields' do
+        it 'submit button is disabled by default' do
+          expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
+        end
+      end
+
+      context 'with all required fields set' do
+        before do
+          fill_in 'custom-stage-name', with: custom_stage_name
+          select_dropdown_option 'custom-stage-start-event', start_event_identifier
+          select_dropdown_option 'custom-stage-stop-event', end_event_identifier
+        end
+
+        it 'does not have label dropdowns' do
+          expect(page).not_to have_content(s_('CustomCycleAnalytics|Start event label'))
+          expect(page).not_to have_content(s_('CustomCycleAnalytics|Stop event label'))
+        end
+
+        it 'submit button is disabled if a default name is used' do
+          fill_in 'custom-stage-name', with: 'issue'
+          click_button(s_('CustomCycleAnalytics|Add stage'))
+
+          expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
+        end
+
+        it 'submit button is disabled if the start event changes' do
+          select_dropdown_option 'custom-stage-start-event', 'issue_created'
+
+          expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
+        end
+
+        include_examples 'submits custom stage form successfully', custom_stage_name
+      end
+
+      context 'with label based stages selected' do
+        before do
+          fill_in 'custom-stage-name', with: custom_stage_with_labels_name
+          select_dropdown_option_by_value 'custom-stage-start-event', start_label_event
+          select_dropdown_option_by_value 'custom-stage-stop-event', stop_label_event
+        end
+
+        it 'submit button is disabled' do
+          expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
+        end
+
+        context 'with labels available' do
+          start_field = 'custom-stage-start-event-label'
+          end_field = 'custom-stage-stop-event-label'
+
+          it 'does not contain labels from outside the group' do
+            wait_for_labels(start_field)
+            menu = page.find("[name=#{start_field}] .dropdown-menu")
+
+            expect(menu).not_to have_content(other_label.name)
+            expect(menu).to have_content(first_label.name)
+            expect(menu).to have_content(second_label.name)
+          end
+
+          context 'with all required fields set' do
+            before do
+              wait_for_labels(start_field)
+              select_dropdown_label start_field, 1
+
+              wait_for_labels(end_field)
+              select_dropdown_label end_field, 2
+            end
+
+            include_examples 'submits custom stage form successfully', custom_stage_with_labels_name
+          end
+        end
+      end
+    end
+  end
+
+  shared_examples 'can edit custom stages' do
+    context 'Edit stage form' do
+      let(:stage_form_class) { '.custom-stage-form' }
+      let(:stage_save_button) { '.js-save-stage' }
+      let(:name_field) { 'custom-stage-name' }
+      let(:start_event_field) { 'custom-stage-start-event' }
+      let(:end_event_field) { 'custom-stage-stop-event' }
+      let(:updated_custom_stage_name) { 'Extra uber cool stage' }
+
+      before do
+        toggle_more_options(first_custom_stage)
+        click_button(_('Edit stage'))
+      end
+
+      context 'with no changes to the data' do
+        it 'prepopulates the stage data and disables submit button' do
+          expect(page.find(stage_form_class)).to have_text(s_('CustomCycleAnalytics|Editing stage'))
+          expect(page.find_field(name_field).value).to eq custom_stage_name
+          expect(page.find_field(start_event_field).value).to eq start_event_identifier.to_s
+          expect(page.find_field(end_event_field).value).to eq end_event_identifier.to_s
+
+          expect(page.find(stage_save_button)[:disabled]).to eq 'true'
+        end
+      end
+
+      context 'with changes' do
+        it 'persists updates to the stage' do
+          fill_in name_field, with: updated_custom_stage_name
+          page.find(stage_save_button).click
+
+          expect(page.find('.flash-notice')).to have_text(_('Stage data updated'))
+          expect(page.find(stage_nav_selector)).not_to have_text custom_stage_name
+          expect(page.find(stage_nav_selector)).to have_text updated_custom_stage_name
+        end
+
+        it 'disables the submit form button if incomplete' do
+          fill_in name_field, with: ''
+
+          expect(page.find(stage_save_button)[:disabled]).to eq 'true'
+        end
+
+        it 'doesnt update the stage if a default name is provided' do
+          fill_in name_field, with: 'issue'
+          page.find(stage_save_button).click
+
+          expect(page.find(stage_form_class)).to have_text(s_('CustomCycleAnalytics|Stage name already exists'))
+        end
+      end
+    end
+  end
+
+  context 'with a group' do
+    context 'selected' do
+      before do
+        select_group
+      end
+
+      it_behaves_like 'can create custom stages' do
+        let(:first_label) { group_label1 }
+        let(:second_label) { group_label2 }
+        let(:other_label) { label }
+      end
+    end
+
+    context 'with a custom stage created' do
+      before do
+        create_custom_stage
+        select_group
+
+        expect(page).to have_text custom_stage_name
+      end
+
+      it_behaves_like 'can edit custom stages'
+    end
+  end
+
+  context 'with a sub group' do
+    context 'selected' do
+      before do
+        select_group(sub_group)
+      end
+
+      it_behaves_like 'can create custom stages' do
+        let(:first_label) { sub_group_label1 }
+        let(:second_label) { sub_group_label2 }
+        let(:other_label) { label }
+      end
+    end
+
+    context 'with a custom stage created' do
+      before do
+        create_custom_stage(sub_group)
+        select_group(sub_group)
+
+        expect(page).to have_text custom_stage_name
+      end
+
+      it_behaves_like 'can edit custom stages'
+    end
+  end
+
+  context 'Stage table' do
+    context 'default stages' do
+      def open_recover_stage_dropdown
+        find(add_stage_button).click
+        click_button(_('Recover hidden stage'))
+      end
+
+      def active_stages
+        page.all('.stage-nav .stage-name').collect(&:text)
+      end
+
+      before do
+        select_group
+
+        toggle_more_options(first_default_stage)
+      end
+
+      it "can be hidden, can't be edited or removed" do
+        expect(first_default_stage.find('.more-actions-dropdown')).to have_text(_('Hide stage'))
+        expect(first_default_stage.find('.more-actions-dropdown')).not_to have_text(_('Edit stage'))
+        expect(first_default_stage.find('.more-actions-dropdown')).not_to have_text(_('Remove stage'))
+      end
+
+      context 'Hide stage' do
+        before do
+          click_button(_('Hide stage'))
+
+          # wait for the stage list to load
+          expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
+        end
+
+        it 'disappears from the stage table & can be recovered' do
+          expect(active_stages).not_to include(s_('CycleAnalyticsStage|Issue'))
+
+          open_recover_stage_dropdown
+
+          expect(page.find('.js-recover-hidden-stage-dropdown')).to have_text(s_('CycleAnalyticsStage|Issue'))
+        end
+      end
+
+      context 'Recover stage' do
+        before do
+          click_button(_('Hide stage'))
+
+          # wait for the stage list to load
+          expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
+        end
+
+        it 'recovers the stage back to the stage table' do
+          open_recover_stage_dropdown
+          click_button(s_('CycleAnalyticsStage|Issue'))
+
+          # wait for the stage list to load
+          expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
+
+          expect(page.find('.flash-notice')).to have_content(_('Stage data updated'))
+          expect(active_stages).to include(s_('CycleAnalyticsStage|Issue'))
+        end
+      end
+    end
+
+    context 'custom stages' do
+      before do
+        create_custom_stage
+        select_group
+
+        expect(page).to have_text custom_stage_name
+
+        toggle_more_options(first_custom_stage)
+      end
+
+      it 'can not be hidden, can be edited or removed' do
+        expect(first_custom_stage.find('.more-actions-dropdown')).not_to have_text(_('Hide stage'))
+        expect(first_custom_stage.find('.more-actions-dropdown')).to have_text(_('Edit stage'))
+        expect(first_custom_stage.find('.more-actions-dropdown')).to have_text(_('Remove stage'))
+      end
+
+      it 'disappears from the stage table after being removed' do
+        nav = page.find(stage_nav_selector)
+        expect(nav).to have_text(custom_stage_name)
+
+        click_button(_('Remove stage'))
+
+        expect(page.find('.flash-notice')).to have_text(_('Stage removed'))
+        expect(nav).not_to have_text(custom_stage_name)
+      end
+    end
+  end
+
+  context 'Duration chart' do
+    let(:duration_chart_dropdown) { page.find(duration_stage_selector) }
+
+    let_it_be(:translated_default_stage_names) do
+      Gitlab::Analytics::CycleAnalytics::DefaultStages.names.map do |name|
+        stage = Analytics::CycleAnalytics::GroupStage.new(name: name)
+        Analytics::CycleAnalytics::StagePresenter.new(stage).title
+      end.freeze
+    end
+
+    def duration_chart_stages
+      duration_chart_dropdown.all('.dropdown-item').collect(&:text)
+    end
+
+    def toggle_duration_chart_dropdown
+      duration_chart_dropdown.click
+    end
+
+    before do
+      select_group
+    end
+
+    it 'has all the default stages' do
+      toggle_duration_chart_dropdown
+
+      expect(duration_chart_stages).to eq(translated_default_stage_names)
+    end
+
+    context 'hidden stage' do
+      before do
+        toggle_more_options(first_default_stage)
+
+        click_button(_('Hide stage'))
+
+        # wait for the stage list to load
+        expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
+      end
+
+      it 'will not appear in the duration chart dropdown' do
+        toggle_duration_chart_dropdown
+
+        expect(duration_chart_stages).not_to include(s_('CycleAnalyticsStage|Issue'))
+      end
+    end
+  end
+end

ee/spec/features/analytics/cycle_analytics/cycle_analytics_spec.rb

@@ -2,22 +2,14 @@
 require 'spec_helper'
 
 RSpec.describe 'Group Value Stream Analytics', :js do
-  include DragTo
-
-  let_it_be(:user) { create(:user) }
   let_it_be(:group) { create(:group, name: 'CA-test-group') }
-  let_it_be(:sub_group) { create(:group, name: 'CA-sub-group', parent: group) }
-  let_it_be(:group2) { create(:group, name: 'CA-bad-test-group') }
   let_it_be(:project) { create(:project, :repository, namespace: group, group: group, name: 'Cool fun project') }
-  let_it_be(:group_label1) { create(:group_label, group: group) }
-  let_it_be(:group_label2) { create(:group_label, group: group) }
-  let_it_be(:label) { create(:group_label, group: group2) }
-  let_it_be(:sub_group_label1) { create(:group_label, group: sub_group) }
-  let_it_be(:sub_group_label2) { create(:group_label, group: sub_group) }
-
-  let(:milestone) { create(:milestone, project: project) }
-  let(:mr) { create_merge_request_closing_issue(user, project, issue, commit_message: "References #{issue.to_reference}") }
-  let(:pipeline) { create(:ci_empty_pipeline, status: 'created', project: project, ref: mr.source_branch, sha: mr.source_branch_sha, head_pipeline_of: mr) }
+  let_it_be(:user) do
+    create(:user).tap do |u|
+      group.add_owner(u)
+      project.add_maintainer(u)
+    end
+  end
 
   stage_nav_selector = '.stage-nav'
   duration_stage_selector = '.js-dropdown-stages'
@@ -30,24 +22,12 @@ RSpec.describe 'Group Value Stream Analytics', :js do
   def select_group(target_group = group)
     visit group_analytics_cycle_analytics_path(target_group)
 
-    wait_for_requests
-  end
-
-  def select_project
-    select_group
-
-    dropdown = page.find('.dropdown-projects')
-    dropdown.click
-    dropdown.find('a').click
-    dropdown.click
+    expect(page).to have_selector '.js-stage-table' # wait_for_stages_to_load
   end
 
   before do
     stub_licensed_features(cycle_analytics_for_groups: true, type_of_work_analytics: true)
 
-    group.add_owner(user)
-    project.add_maintainer(user)
-
     sign_in(user)
   end
 
@@ -60,508 +40,12 @@ RSpec.describe 'Group Value Stream Analytics', :js do
       select_group
     end
 
-    it 'displays the list of stages' do
+    it 'displays the list of stages and duration chart' do
       expect(page).to have_selector(stage_nav_selector, visible: true)
-    end
-
-    it 'displays the duration chart' do
       expect(page).to have_selector(duration_stage_selector, visible: true)
     end
   end
 
-  describe 'Customizable cycle analytics', :js do
-    custom_stage_name = 'Cool beans'
-    custom_stage_with_labels_name = 'Cool beans - now with labels'
-    start_event_identifier = :merge_request_created
-    end_event_identifier = :merge_request_merged
-    start_label_event = :issue_label_added
-    stop_label_event = :issue_label_removed
-
-    let(:add_stage_button) { '.js-add-stage-button' }
-    let(:params) { { name: custom_stage_name, start_event_identifier: start_event_identifier, end_event_identifier: end_event_identifier } }
-    let(:first_default_stage) { page.find('.stage-nav-item-cell', text: 'Issue').ancestor('.stage-nav-item') }
-    let(:first_custom_stage) { page.find('.stage-nav-item-cell', text: custom_stage_name).ancestor('.stage-nav-item') }
-    let(:nav) { page.find(stage_nav_selector) }
-
-    def create_custom_stage(parent_group = group)
-      Analytics::CycleAnalytics::Stages::CreateService.new(parent: parent_group, params: params, current_user: user).execute
-    end
-
-    def toggle_more_options(stage)
-      stage.hover
-
-      stage.find('.more-actions-toggle').click
-    end
-
-    def select_dropdown_option(name, value = start_event_identifier)
-      page.find("select[name='#{name}']").all('option').find { |item| item.value == value.to_s }.select_option
-    end
-
-    def select_dropdown_option_by_value(name, value, elem = 'option')
-      page.find("select[name='#{name}']").find("#{elem}[value=#{value}]").select_option
-    end
-
-    def wait_for_labels(field)
-      page.within("[name=#{field}]") do
-        find('.dropdown-toggle').click
-
-        wait_for_requests
-
-        expect(find('.dropdown-menu')).to have_selector('.dropdown-item')
-      end
-    end
-
-    def select_dropdown_label(field, index = 2)
-      page.find("[name=#{field}] .dropdown-menu").all('.dropdown-item')[index].click
-    end
-
-    def confirm_stage_order(stages)
-      page.within('.stage-nav>ul') do
-        stages.each_with_index do |stage, index|
-          expect(find("li:nth-child(#{index + 1})")).to have_content(stage)
-        end
-      end
-    end
-
-    def drag_from_index_to_index(from, to)
-      drag_to(selector: '.stage-nav>ul',
-        from_index: from,
-        to_index: to)
-    end
-
-    default_stage_order = %w[Issue Plan Code Test Review Staging].freeze
-    default_custom_stage_order = %w[Issue Plan Code Test Review Staging Cool\ beans].freeze
-    stages_near_middle_swapped = %w[Issue Plan Test Code Review Staging Cool\ beans].freeze
-    stage_dragged_to_top = %w[Review Issue Plan Code Test Staging Cool\ beans].freeze
-    stage_dragged_to_bottom = %w[Issue Plan Code Test Staging Cool\ beans Review].freeze
-
-    shared_examples 'manual ordering disabled' do
-      it 'does not allow stages to be draggable', :js do
-        confirm_stage_order(default_stage_order)
-
-        drag_from_index_to_index(0, 1)
-
-        confirm_stage_order(default_stage_order)
-      end
-    end
-
-    context 'enabled' do
-      context 'Manual ordering' do
-        before do
-          select_group
-        end
-
-        context 'with only default stages' do
-          it_behaves_like 'manual ordering disabled'
-        end
-
-        context 'with at least one custom stage', quarantine: 'https://gitlab.com/gitlab-org/gitlab/-/issues/216745' do
-          shared_examples 'draggable stage' do |original_order, updated_order, start_index, end_index,|
-            before do
-              page.driver.browser.manage.window.resize_to(1650, 1150)
-
-              create_custom_stage
-              select_group
-            end
-
-            it 'allows a stage to be dragged' do
-              confirm_stage_order(original_order)
-
-              drag_from_index_to_index(start_index, end_index)
-
-              confirm_stage_order(updated_order)
-            end
-
-            it 'persists the order when a group is selected' do
-              drag_from_index_to_index(start_index, end_index)
-
-              select_group
-
-              confirm_stage_order(updated_order)
-            end
-          end
-
-          context 'dragging a stage to the top', :js do
-            it_behaves_like 'draggable stage', default_custom_stage_order, stage_dragged_to_top, 4, 0
-          end
-
-          context 'dragging a stage to the bottom', :js do
-            it_behaves_like 'draggable stage', default_custom_stage_order, stage_dragged_to_bottom, 4, 7
-          end
-
-          context 'dragging stages in the middle', :js do
-            it_behaves_like 'draggable stage', default_custom_stage_order, stages_near_middle_swapped, 2, 3
-          end
-        end
-      end
-
-      context 'Add a stage button' do
-        before do
-          select_group
-        end
-
-        it 'is visible' do
-          expect(page).to have_selector(add_stage_button, visible: true)
-          expect(page).to have_text(s_('CustomCycleAnalytics|Add a stage'))
-        end
-
-        it 'becomes active when clicked' do
-          expect(page).not_to have_selector("#{add_stage_button}.active")
-
-          find(add_stage_button).click
-
-          expect(page).to have_selector("#{add_stage_button}.active")
-        end
-
-        it 'displays the custom stage form when clicked' do
-          expect(page).not_to have_text(s_('CustomCycleAnalytics|New stage'))
-
-          page.find(add_stage_button).click
-
-          expect(page).to have_text(s_('CustomCycleAnalytics|New stage'))
-        end
-      end
-
-      shared_examples 'can create custom stages' do
-        context 'Custom stage form' do
-          let(:show_form_add_stage_button) { '.js-add-stage-button' }
-
-          before do
-            page.find(show_form_add_stage_button).click
-            wait_for_requests
-          end
-
-          context 'with empty fields' do
-            it 'submit button is disabled by default' do
-              expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
-            end
-          end
-
-          shared_examples 'submits the form successfully' do |stage_name|
-            it 'submit button is enabled' do
-              expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: false)
-            end
-
-            it 'submit button is disabled if the start event changes' do
-              select_dropdown_option 'custom-stage-start-event', 'issue_created'
-
-              expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
-            end
-
-            it 'the custom stage is saved' do
-              click_button(s_('CustomCycleAnalytics|Add stage'))
-
-              expect(page).to have_selector('.stage-nav-item', text: stage_name)
-            end
-
-            it 'a confirmation message is displayed' do
-              fill_in 'custom-stage-name', with: stage_name
-              click_button(s_('CustomCycleAnalytics|Add stage'))
-
-              expect(page.find('.flash-notice')).to have_text(_("Your custom stage '%{title}' was created") % { title: stage_name })
-            end
-
-            it 'with a default name' do
-              fill_in 'custom-stage-name', with: 'issue'
-              click_button(s_('CustomCycleAnalytics|Add stage'))
-
-              expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
-            end
-          end
-
-          context 'with all required fields set' do
-            before do
-              fill_in 'custom-stage-name', with: custom_stage_name
-              select_dropdown_option 'custom-stage-start-event', start_event_identifier
-              select_dropdown_option 'custom-stage-stop-event', end_event_identifier
-            end
-
-            it 'does not have label dropdowns' do
-              expect(page).not_to have_content(s_('CustomCycleAnalytics|Start event label'))
-              expect(page).not_to have_content(s_('CustomCycleAnalytics|Stop event label'))
-            end
-
-            it_behaves_like 'submits the form successfully', custom_stage_name
-          end
-
-          context 'with label based stages selected' do
-            before do
-              fill_in 'custom-stage-name', with: custom_stage_with_labels_name
-              select_dropdown_option_by_value 'custom-stage-start-event', start_label_event
-              select_dropdown_option_by_value 'custom-stage-stop-event', stop_label_event
-            end
-
-            it 'has label dropdowns' do
-              expect(page).to have_content(s_('CustomCycleAnalytics|Start event label'))
-              expect(page).to have_content(s_('CustomCycleAnalytics|Stop event label'))
-            end
-
-            it 'submit button is disabled' do
-              expect(page).to have_button(s_('CustomCycleAnalytics|Add stage'), disabled: true)
-            end
-
-            context 'with labels available' do
-              start_field = 'custom-stage-start-event-label'
-              end_field = 'custom-stage-stop-event-label'
-
-              it 'does not contain labels from outside the group' do
-                wait_for_labels(start_field)
-                menu = page.find("[name=#{start_field}] .dropdown-menu")
-
-                expect(menu).not_to have_content(other_label.name)
-                expect(menu).to have_content(first_label.name)
-                expect(menu).to have_content(second_label.name)
-              end
-
-              context 'with all required fields set' do
-                before do
-                  wait_for_labels(start_field)
-                  select_dropdown_label start_field, 1
-
-                  wait_for_labels(end_field)
-                  select_dropdown_label end_field, 2
-                end
-
-                it_behaves_like 'submits the form successfully', custom_stage_with_labels_name
-              end
-            end
-          end
-        end
-      end
-
-      shared_examples 'can edit custom stages' do
-        context 'Edit stage form' do
-          stage_form_class = '.custom-stage-form'
-          stage_save_button = '.js-save-stage'
-          name_field = 'custom-stage-name'
-          start_event_field = 'custom-stage-start-event'
-          end_event_field = 'custom-stage-stop-event'
-          updated_custom_stage_name = 'Extra uber cool stage'
-
-          def select_edit_stage
-            toggle_more_options(first_custom_stage)
-            click_button(_('Edit stage'))
-          end
-
-          context 'with no changes to the data' do
-            before do
-              select_edit_stage
-            end
-
-            it 'displays the editing stage form' do
-              expect(page.find(stage_form_class)).to have_text(s_('CustomCycleAnalytics|Editing stage'))
-            end
-
-            it 'prepoulates the stage data' do
-              expect(page.find_field(name_field).value).to eq custom_stage_name
-              expect(page.find_field(start_event_field).value).to eq start_event_identifier.to_s
-              expect(page.find_field(end_event_field).value).to eq end_event_identifier.to_s
-            end
-
-            it 'disables the submit form button' do
-              expect(page.find(stage_save_button)[:disabled]).to eq 'true'
-            end
-          end
-
-          context 'with changes' do
-            before do
-              select_edit_stage
-            end
-
-            it 'enables the submit button' do
-              fill_in name_field, with: updated_custom_stage_name
-
-              expect(page.find(stage_save_button)[:disabled]).to eq nil
-            end
-
-            it 'will persist updates to the stage' do
-              fill_in name_field, with: updated_custom_stage_name
-              page.find(stage_save_button).click
-
-              expect(page.find('.flash-notice')).to have_text(_('Stage data updated'))
-              expect(page.find(stage_nav_selector)).not_to have_text custom_stage_name
-              expect(page.find(stage_nav_selector)).to have_text updated_custom_stage_name
-            end
-
-            it 'disables the submit form button if incomplete' do
-              fill_in name_field, with: ''
-
-              expect(page.find(stage_save_button)[:disabled]).to eq 'true'
-            end
-
-            it 'with a default name' do
-              fill_in name_field, with: 'issue'
-              page.find(stage_save_button).click
-
-              expect(page.find(stage_form_class)).to have_text(s_('CustomCycleAnalytics|Stage name already exists'))
-            end
-          end
-        end
-      end
-
-      context 'with a group' do
-        context 'selected' do
-          before do
-            select_group
-          end
-
-          it_behaves_like 'can create custom stages' do
-            let(:first_label) { group_label1 }
-            let(:second_label) { group_label2 }
-            let(:other_label) { label }
-          end
-        end
-
-        context 'with a custom stage created' do
-          before do
-            create_custom_stage
-            select_group
-
-            expect(page).to have_text custom_stage_name
-          end
-
-          it_behaves_like 'can edit custom stages'
-        end
-      end
-
-      context 'with a sub group' do
-        context 'selected' do
-          before do
-            select_group(sub_group)
-          end
-
-          it_behaves_like 'can create custom stages' do
-            let(:first_label) { sub_group_label1 }
-            let(:second_label) { sub_group_label2 }
-            let(:other_label) { label }
-          end
-        end
-
-        context 'with a custom stage created' do
-          before do
-            create_custom_stage(sub_group)
-            select_group(sub_group)
-
-            expect(page).to have_text custom_stage_name
-          end
-
-          it_behaves_like 'can edit custom stages'
-        end
-      end
-
-      context 'Stage table' do
-        context 'default stages' do
-          def open_recover_stage_dropdown
-            find(add_stage_button).click
-
-            expect(page).to have_content(s_('CustomCycleAnalytics|New stage'))
-            expect(page).to have_content(_('Recover hidden stage'))
-
-            click_button(_('Recover hidden stage'))
-
-            within(:css, '.js-recover-hidden-stage-dropdown') do
-              expect(find('.dropdown-menu')).to have_content(_('Default stages'))
-            end
-          end
-
-          def active_stages
-            page.all('.stage-nav .stage-name').collect(&:text)
-          end
-
-          before do
-            select_group
-
-            toggle_more_options(first_default_stage)
-          end
-
-          it 'can be hidden' do
-            expect(first_default_stage.find('.more-actions-dropdown')).to have_text(_('Hide stage'))
-          end
-
-          it 'can not be edited' do
-            expect(first_default_stage.find('.more-actions-dropdown')).not_to have_text(_('Edit stage'))
-          end
-
-          it 'can not be removed' do
-            expect(first_default_stage.find('.more-actions-dropdown')).not_to have_text(_('Remove stage'))
-          end
-
-          context 'hidden' do
-            before do
-              click_button(_('Hide stage'))
-
-              # wait for the stage list to laod
-              expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
-            end
-
-            it 'will not appear in the stage table' do
-              expect(active_stages).not_to include(s_('CycleAnalyticsStage|Issue'))
-            end
-
-            it 'can be recovered' do
-              open_recover_stage_dropdown
-
-              expect(page.find('.js-recover-hidden-stage-dropdown')).to have_text(s_('CycleAnalyticsStage|Issue'))
-            end
-          end
-
-          context 'recovered' do
-            before do
-              click_button(_('Hide stage'))
-
-              # wait for the stage list to laod
-              expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
-            end
-
-            it 'will appear in the stage table' do
-              open_recover_stage_dropdown
-
-              click_button(s_('CycleAnalyticsStage|Issue'))
-              # wait for the stage list to laod
-              expect(nav).to have_content(s_('CycleAnalyticsStage|Plan'))
-
-              expect(page.find('.flash-notice')).to have_content(_('Stage data updated'))
-              expect(active_stages).to include(s_('CycleAnalyticsStage|Issue'))
-            end
-          end
-        end
-
-        context 'custom stages' do
-          before do
-            create_custom_stage
-            select_group
-
-            expect(page).to have_text custom_stage_name
-
-            toggle_more_options(first_custom_stage)
-          end
-
-          it 'can not be hidden' do
-            expect(first_custom_stage.find('.more-actions-dropdown')).not_to have_text(_('Hide stage'))
-          end
-
-          it 'can be edited' do
-            expect(first_custom_stage.find('.more-actions-dropdown')).to have_text(_('Edit stage'))
-          end
-
-          it 'can be removed' do
-            expect(first_custom_stage.find('.more-actions-dropdown')).to have_text(_('Remove stage'))
-          end
-
-          it 'will not appear in the stage table after being removed' do
-            nav = page.find(stage_nav_selector)
-            expect(nav).to have_text(custom_stage_name)
-
-            click_button(_('Remove stage'))
-
-            expect(page.find('.flash-notice')).to have_text(_('Stage removed'))
-            expect(nav).not_to have_text(custom_stage_name)
-          end
-        end
-      end
-    end
-  end
-
   def toggle_value_stream_dropdown
     value_stream_dropdown.click
   end