Merge branch 'es_add_explanation_comments' into 'master'

[ES] Add explanation comments



See merge request !650

app/workers/elastic_indexer_worker.rb

@@ -36,7 +36,13 @@ class ElasticIndexerWorker
       clear_project_indexes(record_id) if klass == Project
     end
   rescue Elasticsearch::Transport::Transport::Errors::NotFound, ActiveRecord::RecordNotFound
-    true # Less work to do!
+    # These errors can happen in several cases, including:
+    # - A record is updated, then removed before the update is handled
+    # - Indexing is enabled, but not every item has been indexed yet - updating
+    #   and deleting the un-indexed records will raise exception
+    #
+    # We can ignore these.
+    true
   end
 
   private

lib/gitlab/elastic/indexer.rb

+# Create a separate process, which does not load the Rails environment, to index
+# each repository. This prevents memory leaks in the indexer from affecting the
+# rest of the application.
 module Gitlab
   module Elastic
     class Indexer