Commit 7132fcf7 authored by Maxime Orefice's avatar Maxime Orefice Committed by Douglas Barbosa Alexandre

Fix JUnit screenshot feature flag

parent 3824edb1
...@@ -180,7 +180,7 @@ class Projects::PipelinesController < Projects::ApplicationController ...@@ -180,7 +180,7 @@ class Projects::PipelinesController < Projects::ApplicationController
render json: TestReportSerializer render json: TestReportSerializer
.new(current_user: @current_user) .new(current_user: @current_user)
.represent(test_reports) .represent(test_reports, project: project)
end end
end end
end end
......
...@@ -789,6 +789,11 @@ describe Projects::PipelinesController do ...@@ -789,6 +789,11 @@ describe Projects::PipelinesController do
end end
end end
context 'when junit_pipeline_screenshots_view is enabled' do
before do
stub_feature_flags(junit_pipeline_screenshots_view: { enabled: true, thing: project })
end
context 'when test_report contains attachment and scope is with_attachment as a URL param' do context 'when test_report contains attachment and scope is with_attachment as a URL param' do
let(:pipeline) { create(:ci_pipeline, :with_test_reports_attachment, project: project) } let(:pipeline) { create(:ci_pipeline, :with_test_reports_attachment, project: project) }
...@@ -797,6 +802,7 @@ describe Projects::PipelinesController do ...@@ -797,6 +802,7 @@ describe Projects::PipelinesController do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
expect(json_response["test_suites"]).to be_present expect(json_response["test_suites"]).to be_present
expect(json_response["test_suites"].first["test_cases"].first).to include("attachment_url")
end end
end end
...@@ -812,6 +818,24 @@ describe Projects::PipelinesController do ...@@ -812,6 +818,24 @@ describe Projects::PipelinesController do
end end
end end
context 'when junit_pipeline_screenshots_view is disabled' do
before do
stub_feature_flags(junit_pipeline_screenshots_view: { enabled: false, thing: project })
end
context 'when test_report contains attachment and scope is with_attachment as a URL param' do
let(:pipeline) { create(:ci_pipeline, :with_test_reports_attachment, project: project) }
it 'returns a test reports without attachment_url' do
get_test_report_json(scope: 'with_attachment')
expect(response).to have_gitlab_http_status(:ok)
expect(json_response["test_suites"].first["test_cases"].first).not_to include("attachment_url")
end
end
end
end
context 'when feature is disabled' do context 'when feature is disabled' do
let(:pipeline) { create(:ci_empty_pipeline, project: project) } let(:pipeline) { create(:ci_empty_pipeline, project: project) }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment