Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7328b143
Commit
7328b143
authored
Mar 22, 2022
by
Pedro Pombeiro
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Track event for new Group runners view
parent
91a42f8a
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletion
+15
-1
app/controllers/groups/runners_controller.rb
app/controllers/groups/runners_controller.rb
+2
-0
spec/controllers/groups/runners_controller_spec.rb
spec/controllers/groups/runners_controller_spec.rb
+13
-1
No files found.
app/controllers/groups/runners_controller.rb
View file @
7328b143
...
...
@@ -11,6 +11,8 @@ class Groups::RunnersController < Groups::ApplicationController
def
index
finder
=
Ci
::
RunnersFinder
.
new
(
current_user:
current_user
,
params:
{
group:
@group
})
@group_runners_limited_count
=
finder
.
execute
.
except
(
:limit
,
:offset
).
page
.
total_count_with_limit
(
:all
,
limit:
1000
)
Gitlab
::
Tracking
.
event
(
self
.
class
.
name
,
'index'
,
user:
current_user
,
namespace:
@group
)
end
def
runner_list_group_view_vue_ui_enabled
...
...
spec/controllers/groups/runners_controller_spec.rb
View file @
7328b143
...
...
@@ -17,7 +17,7 @@ RSpec.describe Groups::RunnersController do
sign_in
(
user
)
end
describe
'#index'
do
describe
'#index'
,
:snowplow
do
context
'when user is owner'
do
before
do
group
.
add_owner
(
user
)
...
...
@@ -30,6 +30,12 @@ RSpec.describe Groups::RunnersController do
expect
(
response
).
to
render_template
(
:index
)
expect
(
assigns
(
:group_runners_limited_count
)).
to
be
(
2
)
end
it
'tracks the event'
do
get
:index
,
params:
{
group_id:
group
}
expect_snowplow_event
(
category:
described_class
.
name
,
action:
'index'
,
user:
user
,
namespace:
group
)
end
end
context
'when user is not owner'
do
...
...
@@ -42,6 +48,12 @@ RSpec.describe Groups::RunnersController do
expect
(
response
).
to
have_gitlab_http_status
(
:not_found
)
end
it
'does not track the event'
do
get
:index
,
params:
{
group_id:
group
}
expect_no_snowplow_event
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment