Commit 733d877a authored by Kirill Smelkov's avatar Kirill Smelkov Committed by Alain Takoudjou

NXD Make HTTP to be the default clone protocol

Both fetch and push are possible over https, which is selected by http if
gitlab was configured to use https in external url.

This way to reduce security vectors and possible ways to interact with gitlab
we use https only without ssh at all.
parent f722a5bf
...@@ -339,6 +339,8 @@ module ProjectsHelper ...@@ -339,6 +339,8 @@ module ProjectsHelper
end end
def default_url_to_repo(project = @project) def default_url_to_repo(project = @project)
# always HTTP:
return project.http_url_to_repo
case default_clone_protocol case default_clone_protocol
when 'ssh' when 'ssh'
project.ssh_url_to_repo project.ssh_url_to_repo
...@@ -348,8 +350,9 @@ module ProjectsHelper ...@@ -348,8 +350,9 @@ module ProjectsHelper
end end
def default_clone_protocol def default_clone_protocol
# always HTTP:
if allowed_protocols_present? if allowed_protocols_present?
enabled_protocol "http"
else else
if !current_user || current_user.require_ssh_key? if !current_user || current_user.require_ssh_key?
gitlab_config.protocol gitlab_config.protocol
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment