Merge branch 'lcharles-fix-2.7-kwargs' into 'master'

Fix Ruby 2.7 deprecations for assorted lib/api classes

See merge request gitlab-org/gitlab!43616

ee/lib/api/visual_review_discussions.rb

@@ -41,10 +41,8 @@ module API
         note = ::Notes::CreateVisualReviewService.new(
           merge_request,
           current_user,
-          {
           body: params[:body],
           position: params[:position]
-          }
         ).execute
 
         if note.valid?

lib/api/helpers/packages_helpers.rb

@@ -40,7 +40,7 @@ module API
 
         params = { has_length: has_length }
         params[:maximum_size] = maximum_size unless has_length
-        ::Packages::PackageFileUploader.workhorse_authorize(params)
+        ::Packages::PackageFileUploader.workhorse_authorize(**params)
       end
 
       def authorize_upload!(subject = user_project)

lib/api/helpers/presentable.rb

@@ -23,7 +23,7 @@ module API
 
       def initialize(object, options = {})
         options = options.opts_hash if options.is_a?(Grape::Entity::Options)
-        super(object.present(options), options)
+        super(object.present(options), **options)
       end
     end
   end

lib/api/nuget_packages.rb

@@ -42,7 +42,7 @@ module API
       def package_finder(finder_params = {})
         ::Packages::Nuget::PackageFinder.new(
           authorized_user_project,
-          finder_params.merge(package_name: params[:package_name])
+          **finder_params.merge(package_name: params[:package_name])
         )
       end
     end

lib/api/project_export.rb

@@ -55,7 +55,7 @@ module API
         export_strategy = if after_export_params[:url].present?
                             params = after_export_params.slice(:url, :http_method).symbolize_keys
 
-                            Gitlab::ImportExport::AfterExportStrategies::WebUploadStrategy.new(params)
+                            Gitlab::ImportExport::AfterExportStrategies::WebUploadStrategy.new(**params)
                           end
 
         if export_strategy&.invalid?

lib/api/v3/github.rb

@@ -51,7 +51,7 @@ module API
 
         def find_project_with_access(params)
           project = find_project!(
-            ::Gitlab::Jira::Dvcs.restore_full_path(params.slice(:namespace, :project).symbolize_keys)
+            ::Gitlab::Jira::Dvcs.restore_full_path(**params.slice(:namespace, :project).symbolize_keys)
           )
           not_found! unless can?(current_user, :download_code, project)
           project