Merge branch 'winh-eslint-promise/no-nesting-user_popovers.js' into 'master'

Remove nested Promise from user popover

See merge request gitlab-org/gitlab!17688

app/assets/javascripts/user_popovers.js

@@ -63,7 +63,7 @@ const handleUserPopoverMouseOver = event => {
       UsersCache.retrieveById(userId)
         .then(userData => {
           if (!userData) {
-            return;
+            return undefined;
           }
 
           Object.assign(user, {
@@ -76,7 +76,8 @@ const handleUserPopoverMouseOver = event => {
             loaded: true,
           });
 
-          UsersCache.retrieveStatusById(userId)
+          return UsersCache.retrieveStatusById(userId);
+        })
         .then(status => {
           if (!status) {
             return;
@@ -86,10 +87,6 @@ const handleUserPopoverMouseOver = event => {
             status,
           });
         })
-            .catch(() => {
-              throw new Error(`User status for "${userId}" could not be retrieved!`);
-            });
-        })
         .catch(() => {
           renderedPopover.$destroy();
           renderedPopover = null;