Merge branch 'fix-delete-action-package' into 'master'

Fix delete action for package tests See merge request gitlab-org/gitlab!52718

Merge branch 'fix-delete-action-package' into 'master'
Fix delete action for package tests See merge request gitlab-org/gitlab!52718
79d9a022 · Mark Lapierre · a60f6aa7 · 2fe09748 · 79d9a022 · 79d9a022
Commit 79d9a022 authored Jan 28, 2021 by Mark Lapierre
6 changed files
--- a/qa/qa/specs/features/browser_ui/5_package/composer_registry_spec.rb
+++ b/qa/qa/specs/features/browser_ui/5_package/composer_registry_spec.rb
@@ -104,9 +104,7 @@ module QA
          index.click_package(package_name)
        end
-        Page::Project::Packages::Show.perform do |package|
+        Page::Project::Packages::Show.perform(&:click_delete)
-          package.click_delete
-        end
        Page::Project::Packages::Index.perform do |index|
          aggregate_failures 'package deletion' do

--- a/qa/qa/specs/features/browser_ui/5_package/conan_repository_spec.rb
+++ b/qa/qa/specs/features/browser_ui/5_package/conan_repository_spec.rb
@@ -75,9 +75,7 @@ module QA
          index.click_package(package_name)
        end
-        Page::Project::Packages::Show.perform do |package|
+        Page::Project::Packages::Show.perform(&:click_delete)
-          package.click_delete
-        end
        Page::Project::Packages::Index.perform do |index|
          expect(index).to have_content("Package deleted successfully")

--- a/qa/qa/specs/features/browser_ui/5_package/generic_repository_spec.rb
+++ b/qa/qa/specs/features/browser_ui/5_package/generic_repository_spec.rb
@@ -100,9 +100,7 @@ module QA
          index.click_package(package_name)
        end
-        Page::Project::Packages::Show.perform do |package|
+        Page::Project::Packages::Show.perform(&:click_delete)
-          package.click_delete
-        end
        Page::Project::Packages::Index.perform do |index|
          aggregate_failures 'package deletion' do

--- a/qa/qa/specs/features/browser_ui/5_package/maven_gradle_repository_spec.rb
+++ b/qa/qa/specs/features/browser_ui/5_package/maven_gradle_repository_spec.rb
@@ -112,9 +112,7 @@ module QA
          index.click_package(package_name)
        end
-        Page::Project::Packages::Show.perform do |show|
+        Page::Project::Packages::Show.perform(&:click_delete)
-          show.click_delete
-        end
        Page::Project::Packages::Index.perform do |index|
          expect(index).to have_content("Package deleted successfully")

--- a/qa/qa/specs/features/browser_ui/5_package/nuget_repository_spec.rb
+++ b/qa/qa/specs/features/browser_ui/5_package/nuget_repository_spec.rb
@@ -155,9 +155,7 @@ module QA
          index.click_package(package_name)
        end
-        Page::Project::Packages::Show.perform do |package|
+        Page::Project::Packages::Show.perform(&:click_delete)
-          package.click_delete
-        end
        Page::Project::Packages::Index.perform do |index|
          expect(index).to have_content("Package deleted successfully")

--- a/qa/qa/specs/features/browser_ui/5_package/pypi_repository_spec.rb
+++ b/qa/qa/specs/features/browser_ui/5_package/pypi_repository_spec.rb
@@ -98,9 +98,7 @@ module QA
          index.click_package(package_name)
        end
-        Page::Project::Packages::Show.perform do |package|
+        Page::Project::Packages::Show.perform(&:click_delete)
-          package.click_delete
-        end
        Page::Project::Packages::Index.perform do |index|
          aggregate_failures do