Commit 7a068c43 authored by Mayra Cabrera's avatar Mayra Cabrera

Merge branch 'remove_unnecessary_method_override' into 'master'

Remove unnecessary override of `build_comparer` method

See merge request gitlab-org/gitlab!39999
parents a3326387 28f79ee4
......@@ -13,9 +13,5 @@ module Ci
def get_report(pipeline)
Security::PipelineVulnerabilitiesFinder.new(pipeline: pipeline, params: { report_type: [params[:report_type]], scope: 'all' }).execute
end
def build_comparer(base_pipeline, head_pipeline)
comparer_class.new(get_report(base_pipeline), get_report(head_pipeline))
end
end
end
......@@ -82,16 +82,6 @@ RSpec.describe Ci::CompareSecurityReportsService do
expect(result[:status_reason]).to include('JSON parsing failed')
end
end
describe "#build_comparer" do
context "when the head_pipeline is nil" do
subject { service.build_comparer(base_pipeline, nil) }
let(:base_pipeline) { create(:ee_ci_pipeline) }
specify { expect { subject }.not_to raise_error }
end
end
end
describe '#execute CS' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment