Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7ae8d70c
Commit
7ae8d70c
authored
Feb 11, 2022
by
Jonathan Schafer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Create new feature flag
parent
a6d2e203
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
3 deletions
+11
-3
config/feature_flags/development/read_from_vulnerability_finding_evidence.yml
.../development/read_from_vulnerability_finding_evidence.yml
+8
-0
ee/app/models/vulnerabilities/finding.rb
ee/app/models/vulnerabilities/finding.rb
+1
-1
ee/spec/models/vulnerabilities/finding_spec.rb
ee/spec/models/vulnerabilities/finding_spec.rb
+2
-2
No files found.
config/feature_flags/development/read_from_vulnerability_finding_evidence.yml
0 → 100644
View file @
7ae8d70c
---
name
:
read_from_vulnerability_finding_evidence
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/79883
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/352632
milestone
:
'
14.8'
type
:
development
group
:
group::threat insights
default_enabled
:
false
ee/app/models/vulnerabilities/finding.rb
View file @
7ae8d70c
...
@@ -291,7 +291,7 @@ module Vulnerabilities
...
@@ -291,7 +291,7 @@ module Vulnerabilities
end
end
def
evidence
def
evidence
evidence_data
=
finding_evidence
.
present?
&&
Feature
.
enabled?
(
:
vulnerability_finding_replace_metadata
)
?
finding_evidence
.
data
:
metadata
.
dig
(
'evidence'
)
evidence_data
=
finding_evidence
.
present?
&&
Feature
.
enabled?
(
:
read_from_vulnerability_finding_evidence
)
?
finding_evidence
.
data
:
metadata
.
dig
(
'evidence'
)
{
{
summary:
evidence_data
&
.
dig
(
'summary'
),
summary:
evidence_data
&
.
dig
(
'summary'
),
...
...
ee/spec/models/vulnerabilities/finding_spec.rb
View file @
7ae8d70c
...
@@ -909,7 +909,7 @@ RSpec.describe Vulnerabilities::Finding do
...
@@ -909,7 +909,7 @@ RSpec.describe Vulnerabilities::Finding do
let
(
:evidence
)
{
finding
.
metadata
[
'evidence'
]
}
let
(
:evidence
)
{
finding
.
metadata
[
'evidence'
]
}
before
do
before
do
stub_feature_flags
(
vulnerability_finding_replace_metadata
:
false
)
stub_feature_flags
(
read_from_vulnerability_finding_evidence
:
false
)
end
end
include_examples
'evidence schema'
include_examples
'evidence schema'
...
@@ -919,7 +919,7 @@ RSpec.describe Vulnerabilities::Finding do
...
@@ -919,7 +919,7 @@ RSpec.describe Vulnerabilities::Finding do
let
(
:evidence
)
{
finding_evidence
.
data
}
let
(
:evidence
)
{
finding_evidence
.
data
}
before
do
before
do
stub_feature_flags
(
vulnerability_finding_replace_metadata
:
true
)
stub_feature_flags
(
read_from_vulnerability_finding_evidence
:
true
)
end
end
include_examples
'evidence schema'
include_examples
'evidence schema'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment