Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7cfaccd6
Commit
7cfaccd6
authored
Sep 26, 2017
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix code style offenses in pipeline create services
parent
3420c0f7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
2 additions
and
4 deletions
+2
-4
app/services/ci/create_pipeline_service.rb
app/services/ci/create_pipeline_service.rb
+1
-2
lib/gitlab/ci/pipeline/chain/validate.rb
lib/gitlab/ci/pipeline/chain/validate.rb
+1
-1
spec/services/ci/create_pipeline_service_spec.rb
spec/services/ci/create_pipeline_service_spec.rb
+0
-1
No files found.
app/services/ci/create_pipeline_service.rb
View file @
7cfaccd6
...
@@ -3,7 +3,7 @@ module Ci
...
@@ -3,7 +3,7 @@ module Ci
attr_reader
:pipeline
attr_reader
:pipeline
SEQUENCE
=
[
Gitlab
::
Ci
::
Pipeline
::
Chain
::
Validate
,
SEQUENCE
=
[
Gitlab
::
Ci
::
Pipeline
::
Chain
::
Validate
,
Gitlab
::
Ci
::
Pipeline
::
Chain
::
Skip
]
Gitlab
::
Ci
::
Pipeline
::
Chain
::
Skip
]
.
freeze
def
execute
(
source
,
ignore_skip_ci:
false
,
save_on_errors:
true
,
trigger_request:
nil
,
schedule:
nil
)
def
execute
(
source
,
ignore_skip_ci:
false
,
save_on_errors:
true
,
trigger_request:
nil
,
schedule:
nil
)
@pipeline
=
Ci
::
Pipeline
.
new
(
@pipeline
=
Ci
::
Pipeline
.
new
(
...
@@ -91,7 +91,6 @@ module Ci
...
@@ -91,7 +91,6 @@ module Ci
.
created_or_pending
.
created_or_pending
end
end
def
before_sha
def
before_sha
params
[
:checkout_sha
]
||
params
[
:before
]
||
Gitlab
::
Git
::
BLANK_SHA
params
[
:checkout_sha
]
||
params
[
:before
]
||
Gitlab
::
Git
::
BLANK_SHA
end
end
...
...
lib/gitlab/ci/pipeline/chain/validate.rb
View file @
7cfaccd6
...
@@ -10,7 +10,7 @@ module Gitlab
...
@@ -10,7 +10,7 @@ module Gitlab
end
end
def
break?
def
break?
@pipeline
.
errors
.
any?
||
@pipeline
.
persisted?
@pipeline
.
errors
.
any?
||
@pipeline
.
persisted?
end
end
def
allowed_to_trigger_pipeline?
def
allowed_to_trigger_pipeline?
...
...
spec/services/ci/create_pipeline_service_spec.rb
View file @
7cfaccd6
...
@@ -481,5 +481,4 @@ describe Ci::CreatePipelineService do
...
@@ -481,5 +481,4 @@ describe Ci::CreatePipelineService do
end
end
end
end
end
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment