Commit 7e972b77 authored by Kev's avatar Kev

Change event structure in vulnerability component

parent 5caab361
...@@ -209,15 +209,6 @@ export default { ...@@ -209,15 +209,6 @@ export default {
}); });
}, },
}, },
created() {
this.$on('vulnerability-state-change', newState => {
// Indicates that the event emitter does not know the new state
if (!newState) {
this.refreshVulnerability();
}
});
},
}; };
</script> </script>
......
<script> <script>
import Vue from 'vue'; import { VULNERABILITY_STATE_OBJECTS } from 'ee/vulnerabilities/constants';
import VulnerabilityHeader from './header.vue'; import VulnerabilityHeader from './header.vue';
import VulnerabilityDetails from './details.vue'; import VulnerabilityDetails from './details.vue';
import VulnerabilityFooter from './footer.vue'; import VulnerabilityFooter from './footer.vue';
import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils'; import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils';
import { VULNERABILITY_STATE_OBJECTS } from 'ee/vulnerabilities/constants';
export default { export default {
// eslint-disable-next-line @gitlab/require-i18n-strings
name: 'Vulnerability', name: 'Vulnerability',
components: { VulnerabilityHeader, VulnerabilityDetails, VulnerabilityFooter }, components: { VulnerabilityHeader, VulnerabilityDetails, VulnerabilityFooter },
...@@ -19,7 +19,7 @@ export default { ...@@ -19,7 +19,7 @@ export default {
}, },
computed: { computed: {
footerInfo: function() { footerInfo() {
const { const {
vulnerabilityFeedbackHelpPath, vulnerabilityFeedbackHelpPath,
hasMr, hasMr,
...@@ -29,7 +29,6 @@ export default { ...@@ -29,7 +29,6 @@ export default {
issueFeedback, issueFeedback,
mergeRequestFeedback, mergeRequestFeedback,
notesUrl, notesUrl,
project,
projectFingerprint, projectFingerprint,
remediations, remediations,
reportType, reportType,
...@@ -76,9 +75,12 @@ export default { ...@@ -76,9 +75,12 @@ export default {
}, },
methods: { methods: {
handleVulnerabilityStateChange(a) { handleVulnerabilityStateChange(newState) {
console.error('state-change', this.footerInfo); if (newState) {
this.$refs.footer.fetchDiscussions(); this.$refs.footer.fetchDiscussions();
} else {
this.$refs.header.refreshVulnerability();
}
}, },
}, },
}; };
...@@ -87,14 +89,15 @@ export default { ...@@ -87,14 +89,15 @@ export default {
<template> <template>
<div> <div>
<vulnerability-header <vulnerability-header
:initialVulnerability="vulnerability" ref="header"
v-on:vulnerability-state-change="handleVulnerabilityStateChange" :initial-vulnerability="vulnerability"
></vulnerability-header> @vulnerability-state-change="handleVulnerabilityStateChange"
<vulnerability-details :vulnerability="vulnerability"></vulnerability-details> />
<vulnerability-details :vulnerability="vulnerability" />
<vulnerability-footer <vulnerability-footer
v-bind="footerInfo"
v-on:vulnerability-state-change="handleVulnerabilityStateChange"
ref="footer" ref="footer"
></vulnerability-footer> v-bind="footerInfo"
@vulnerability-state-change="handleVulnerabilityStateChange"
/>
</div> </div>
</template> </template>
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment