Add latest changes from gitlab-org/gitlab@master

doc/administration/gitaly/praefect.md

@@ -20,7 +20,7 @@ graph TB
 
 Where `GitLab` is the collection of clients that can request Git operations.
 `Gitaly` is a Gitaly server before using Praefect. The Praefect node has two
-storage nodes attached. Praefect itself doesn't storage data, but connects to
+storage nodes attached. Praefect itself doesn't store data, but connects to
 three Gitaly nodes, `Praefect-Git-1`,  `Praefect-Git-2`, and `Praefect-Git-3`.
 There should be no knowledge other than with Praefect about the existence of
 the `Praefect-Git-X` nodes.

spec/validators/branch_filter_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe BranchFilterValidator do
@@ -6,25 +8,25 @@ describe BranchFilterValidator do
 
   describe '#validates_each' do
     it 'allows valid branch names' do
-      validator.validate_each(hook, :push_events_branch_filter, "good_branch_name")
-      validator.validate_each(hook, :push_events_branch_filter, "another/good_branch_name")
+      validator.validate_each(hook, :push_events_branch_filter, +"good_branch_name")
+      validator.validate_each(hook, :push_events_branch_filter, +"another/good_branch_name")
       expect(hook.errors.empty?).to be true
     end
 
     it 'disallows bad branch names' do
-      validator.validate_each(hook, :push_events_branch_filter, "bad branch~name")
+      validator.validate_each(hook, :push_events_branch_filter, +"bad branch~name")
       expect(hook.errors[:push_events_branch_filter].empty?).to be false
     end
 
     it 'allows wildcards' do
-      validator.validate_each(hook, :push_events_branch_filter, "features/*")
-      validator.validate_each(hook, :push_events_branch_filter, "features/*/bla")
-      validator.validate_each(hook, :push_events_branch_filter, "*-stable")
+      validator.validate_each(hook, :push_events_branch_filter, +"features/*")
+      validator.validate_each(hook, :push_events_branch_filter, +"features/*/bla")
+      validator.validate_each(hook, :push_events_branch_filter, +"*-stable")
       expect(hook.errors.empty?).to be true
     end
 
     it 'gets rid of whitespace' do
-      filter = ' master '
+      filter = +' master '
       validator.validate_each(hook, :push_events_branch_filter, filter)
 
       expect(filter).to eq 'master'

spec/validators/js_regex_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe JsRegexValidator do

spec/validators/namespace_path_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe NamespacePathValidator do
@@ -5,7 +7,7 @@ describe NamespacePathValidator do
 
   describe '.valid_path?' do
     it 'handles invalid utf8' do
-      expect(described_class.valid_path?("a\0weird\255path")).to be_falsey
+      expect(described_class.valid_path?(+"a\0weird\255path")).to be_falsey
     end
   end
 

spec/validators/project_path_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ProjectPathValidator do
@@ -5,7 +7,7 @@ describe ProjectPathValidator do
 
   describe '.valid_path?' do
     it 'handles invalid utf8' do
-      expect(described_class.valid_path?("a\0weird\255path")).to be_falsey
+      expect(described_class.valid_path?(+"a\0weird\255path")).to be_falsey
     end
   end
 

spec/validators/public_url_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe PublicUrlValidator do

spec/validators/variable_duplicates_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe VariableDuplicatesValidator do

spec/validators/x509_certificate_credentials_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe X509CertificateCredentialsValidator do