Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
7fd7a57d
Commit
7fd7a57d
authored
Aug 05, 2020
by
Sarah Groff Hennigh-Palermo
Committed by
Dan Davison
Aug 05, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Re-add data-qa selector
parent
8e0c7cdf
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
2 deletions
+3
-2
app/assets/javascripts/ci_variable_list/components/ci_variable_modal.vue
...scripts/ci_variable_list/components/ci_variable_modal.vue
+1
-0
qa/qa/page/project/settings/ci_variables.rb
qa/qa/page/project/settings/ci_variables.rb
+1
-1
qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb
...er_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb
+1
-1
No files found.
app/assets/javascripts/ci_variable_list/components/ci_variable_modal.vue
View file @
7fd7a57d
...
@@ -210,6 +210,7 @@ export default {
...
@@ -210,6 +210,7 @@ export default {
v-model=
"key"
v-model=
"key"
:token-list=
"$options.tokenList"
:token-list=
"$options.tokenList"
:label-text=
"__('Key')"
:label-text=
"__('Key')"
data-qa-selector=
"ci_variable_key_field"
/>
/>
<gl-form-group
v-else
:label=
"__('Key')"
label-for=
"ci-variable-key"
>
<gl-form-group
v-else
:label=
"__('Key')"
label-for=
"ci-variable-key"
>
...
...
qa/qa/page/project/settings/ci_variables.rb
View file @
7fd7a57d
...
@@ -23,7 +23,7 @@ module QA
...
@@ -23,7 +23,7 @@ module QA
end
end
def
fill_variable
(
key
,
value
,
masked
)
def
fill_variable
(
key
,
value
,
masked
)
fill_element
:ci_variable_key_field
,
key
within_element
(
:ci_variable_key_field
)
{
find
(
'input'
).
set
key
}
fill_element
:ci_variable_value_field
,
value
fill_element
:ci_variable_value_field
,
value
click_ci_variable_save_button
click_ci_variable_save_button
end
end
...
...
qa/qa/specs/features/browser_ui/4_verify/ci_variable/add_remove_ci_variable_spec.rb
View file @
7fd7a57d
# frozen_string_literal: true
# frozen_string_literal: true
module
QA
module
QA
RSpec
.
describe
'Verify'
,
quarantine:
{
issue:
'https://gitlab.com/gitlab-org/gitlab/-/issues/229724'
,
type: :investigating
}
do
RSpec
.
describe
'Verify'
do
describe
'Add or Remove CI variable via UI'
,
:smoke
do
describe
'Add or Remove CI variable via UI'
,
:smoke
do
let!
(
:project
)
do
let!
(
:project
)
do
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment