Merge branch 'fj-fix-bug-snippet-repository-creation' into 'master'

Fix bug when snippet is created

See merge request gitlab-org/gitlab!25372

app/services/snippets/create_service.rb

@@ -24,8 +24,8 @@ module Snippets
       spam_check(snippet, current_user)
 
       snippet_saved = snippet.with_transaction_returning_status do
-        if snippet.save && snippet.store_mentions!
-          create_repository_for(snippet, current_user)
+        (snippet.save && snippet.store_mentions!).tap do |saved|
+          create_repository_for(snippet, current_user) if saved
         end
       end
 

spec/services/snippets/create_service_spec.rb

@@ -164,7 +164,9 @@ describe Snippets::CreateService do
         it 'does not create snippet repository' do
           stub_feature_flags(version_snippets: false)
 
+          expect do
             subject
+          end.to change(Snippet, :count).by(1)
 
           expect(snippet.repository_exists?).to be_falsey
         end