Commit 81df201b authored by Markus Koller's avatar Markus Koller

Don't verify module path for Naming/FileName cop

This causes false positives if the GitLab project is checked out inside
a directory called `src`, which Rubocop incorrectly detects as the
project root.

In practice this verification only seems to work correctly for certain
directories like `lib/` anyway, for `app/` it only considers the
filename and looks for a matching class definition, but ignores the
module namespace.

Also see https://github.com/rubocop/rubocop/issues/6289
parent 2065b14d
...@@ -106,6 +106,7 @@ RSpec/MultipleMemoizedHelpers: ...@@ -106,6 +106,7 @@ RSpec/MultipleMemoizedHelpers:
Naming/FileName: Naming/FileName:
ExpectMatchingDefinition: true ExpectMatchingDefinition: true
CheckDefinitionPathHierarchy: false
Exclude: Exclude:
- '**/*/*.builder' - '**/*/*.builder'
- 'ee/bin/*' - 'ee/bin/*'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment