Resolve "Dynamic Element Validation Iteration: Improve waiting"

81eabfea · Dan Davison · Walmyr Lima e Silva Filho · 338b7238 · 81eabfea
Commit 81eabfea authored Jan 10, 2020 by Dan Davison Committed by Walmyr Lima e Silva Filho Jan 10, 2020
Show whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

qa/qa/page/validatable.rb qa/qa/page/validatable.rb +1 -2

No files found.
--- a/qa/qa/page/validatable.rb
+++ b/qa/qa/page/validatable.rb
@@ -11,8 +11,7 @@ module QA
        elements.each do |element|
          next unless element.required?

-          # TODO: this wait needs to be replaced by the wait class
-          unless base_page.has_element?(element.name, wait: 60)
+          unless base_page.wait(reload: false) { base_page.has_element?(element.name, wait: 15) }
            raise Validatable::PageValidationError, "#{element.name} did not appear on #{self.name} as expected"
          end
        end