Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
826d6526
Commit
826d6526
authored
May 06, 2017
by
Valery Sizov
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve interpret_service.rb and its spec
parent
0ff8316b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
37 deletions
+11
-37
app/services/slash_commands/interpret_service.rb
app/services/slash_commands/interpret_service.rb
+11
-17
spec/services/slash_commands/interpret_service_spec.rb
spec/services/slash_commands/interpret_service_spec.rb
+0
-20
No files found.
app/services/slash_commands/interpret_service.rb
View file @
826d6526
...
...
@@ -91,36 +91,30 @@ module SlashCommands
end
desc
'Assign'
explanation
do
|
user
|
"Assigns
#{
user
.
to_reference
}
."
if
user
explanation
do
|
user
s
|
"Assigns
#{
user
s
.
map
(
&
:to_reference
).
to_sentence
}
."
if
users
.
any?
end
params
'@user'
condition
do
current_user
.
can?
(
:"admin_
#{
issuable
.
to_ability_name
}
"
,
project
)
end
<<<<<<<
HEAD
parse_params
do
|
assignee_param
|
extract_references
(
assignee_param
,
:user
).
first
||
User
.
find_by
(
username:
assignee_param
)
end
command
:assign
do
|
user
|
@updates
[
:assignee_id
]
=
user
.
id
if
user
=======
command
:assign
do
|
assignee_param
|
user_ids
=
extract_references
(
assignee_param
,
:user
).
map
(
&
:id
)
users
=
extract_references
(
assignee_param
,
:user
)
if
user
_id
s
.
empty?
user
_ids
=
User
.
where
(
username:
assignee_param
.
split
(
' '
).
map
(
&
:strip
)).
pluck
(
:id
)
if
users
.
empty?
user
s
=
User
.
where
(
username:
assignee_param
.
split
(
' '
).
map
(
&
:strip
)
)
end
next
if
user_ids
.
empty?
users
end
command
:assign
do
|
users
|
next
if
users
.
empty?
if
issuable
.
is_a?
(
Issue
)
@updates
[
:assignee_ids
]
=
user
_ids
@updates
[
:assignee_ids
]
=
user
s
.
map
(
&
:id
)
else
@updates
[
:assignee_id
]
=
user
_ids
.
last
@updates
[
:assignee_id
]
=
user
s
.
last
.
id
end
>>>>>>>
origin
/
multiple_assignees_review
end
desc
'Remove assignee'
...
...
spec/services/slash_commands/interpret_service_spec.rb
View file @
826d6526
...
...
@@ -43,26 +43,6 @@ describe SlashCommands::InterpretService, services: true do
end
end
<<<<<<<
HEAD
shared_examples
'assign command'
do
it
'fetches assignee and populates assignee_id if content contains /assign'
do
_
,
updates
=
service
.
execute
(
content
,
issuable
)
expect
(
updates
).
to
eq
(
assignee_id:
developer
.
id
)
end
end
shared_examples
'unassign command'
do
it
'populates assignee_id: nil if content contains /unassign'
do
issuable
.
update!
(
assignee_id:
developer
.
id
)
_
,
updates
=
service
.
execute
(
content
,
issuable
)
expect
(
updates
).
to
eq
(
assignee_id:
nil
)
end
end
=======
>>>>>>>
origin
/
multiple_assignees_review
shared_examples
'milestone command'
do
it
'fetches milestone and populates milestone_id if content contains /milestone'
do
milestone
# populate the milestone
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment