Simplify conditions

82a05423 · Kushal Pandya · 1278b5ce · 82a05423
Commit 82a05423 authored Feb 07, 2017 by Kushal Pandya
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

app/assets/javascripts/merge_request_tabs.js.es6 app/assets/javascripts/merge_request_tabs.js.es6 +3 -5

No files found.
--- a/app/assets/javascripts/merge_request_tabs.js.es6
+++ b/app/assets/javascripts/merge_request_tabs.js.es6
@@ -102,12 +102,10 @@ require('./flash');
    }
    clickTab(e) {
-      if (e.target) {
+      if (e.target && gl.utils.isMetaClick(e)) {
        const targetLink = e.target.getAttribute('href');
-        if (gl.utils.isMetaClick(e)) {
+        e.stopImmediatePropagation();
-          e.stopImmediatePropagation();
+        window.open(targetLink, '_blank');
-          window.open(targetLink, '_blank');
-        }
      }
    }