Merge branch '342747-hide-empty-row-if-no-badge' into 'master'

Hide badge row if there are no pipeline badges

See merge request gitlab-org/gitlab!72538

app/helpers/ci/pipelines_helper.rb

@@ -67,6 +67,17 @@ module Ci
       ]
     end
 
+    def has_pipeline_badges?(pipeline)
+      pipeline.child? ||
+        pipeline.latest? ||
+        pipeline.merge_train_pipeline? ||
+        pipeline.has_yaml_errors? ||
+        pipeline.failure_reason? ||
+        pipeline.auto_devops_source? ||
+        pipeline.detached_merge_request_pipeline? ||
+        pipeline.stuck?
+    end
+
     private
 
     def warning_markdown(pipeline)

app/views/projects/pipelines/_info.html.haml

@@ -17,6 +17,7 @@
     - if @pipeline.queued_duration
       = "(queued for #{time_interval_in_words(@pipeline.queued_duration)})"
 
+  - if has_pipeline_badges?(@pipeline)
     .well-segment.qa-pipeline-badges
       .icon-container
         = sprite_icon('flag')

spec/helpers/ci/pipelines_helper_spec.rb

@@ -71,4 +71,26 @@ RSpec.describe Ci::PipelinesHelper do
       it { expect(has_gitlab_ci?).to eq(result) }
     end
   end
+
+  describe 'has_pipeline_badges?' do
+    let(:pipeline) { create(:ci_empty_pipeline) }
+
+    subject { helper.has_pipeline_badges?(pipeline) }
+
+    context 'when pipeline has a badge' do
+      before do
+        pipeline.drop!(:config_error)
+      end
+
+      it 'shows pipeline badges' do
+        expect(subject).to eq(true)
+      end
+    end
+
+    context 'when pipeline has no badges' do
+      it 'shows pipeline badges' do
+        expect(subject).to eq(false)
+      end
+    end
+  end
 end