Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
85441fae
Commit
85441fae
authored
Oct 18, 2021
by
Kolja Lucht
Committed by
Kati Paizee
Oct 18, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve wording of e.g and i.e. instances
parent
80796768
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
6 deletions
+6
-6
doc/development/sql.md
doc/development/sql.md
+1
-1
doc/development/testing_guide/end_to_end/dynamic_element_validation.md
...nt/testing_guide/end_to_end/dynamic_element_validation.md
+1
-1
doc/development/testing_guide/end_to_end/page_objects.md
doc/development/testing_guide/end_to_end/page_objects.md
+1
-1
doc/development/testing_guide/flaky_tests.md
doc/development/testing_guide/flaky_tests.md
+2
-2
doc/development/windows.md
doc/development/windows.md
+1
-1
No files found.
doc/development/sql.md
View file @
85441fae
...
@@ -241,7 +241,7 @@ MergeRequest.where(source_project_id: Project.all.select(:id))
...
@@ -241,7 +241,7 @@ MergeRequest.where(source_project_id: Project.all.select(:id))
```
```
The _only_ time you should use
`pluck`
is when you actually need to operate on
The _only_ time you should use
`pluck`
is when you actually need to operate on
the values in Ruby itself (
e.g. write
them to a file). In almost all other cases
the values in Ruby itself (
for example, writing
them to a file). In almost all other cases
you should ask yourself "Can I not just use a sub-query?".
you should ask yourself "Can I not just use a sub-query?".
In line with our
`CodeReuse/ActiveRecord`
cop, you should only use forms like
In line with our
`CodeReuse/ActiveRecord`
cop, you should only use forms like
...
...
doc/development/testing_guide/end_to_end/dynamic_element_validation.md
View file @
85441fae
...
@@ -52,7 +52,7 @@ Simply put, a required element is a visible HTML element that appears on a UI co
...
@@ -52,7 +52,7 @@ Simply put, a required element is a visible HTML element that appears on a UI co
"Visible" can be defined as
"Visible" can be defined as
-
Not having any CSS preventing its display
. E.g.:
`display: none`
or
`width: 0px; height: 0px;`
-
Not having any CSS preventing its display
, for example,
`display: none`
or
`width: 0px; height: 0px;`
-
Being able to be interacted with by the user
-
Being able to be interacted with by the user
"UI component" can be defined as
"UI component" can be defined as
...
...
doc/development/testing_guide/end_to_end/page_objects.md
View file @
85441fae
...
@@ -105,7 +105,7 @@ code but **this is deprecated** in favor of the above method for two reasons:
...
@@ -105,7 +105,7 @@ code but **this is deprecated** in favor of the above method for two reasons:
-
Consistency: there is only one way to define an element
-
Consistency: there is only one way to define an element
-
Separation of concerns: QA uses dedicated
`data-qa-*`
attributes instead of reusing code
-
Separation of concerns: QA uses dedicated
`data-qa-*`
attributes instead of reusing code
or classes used by other components (
e.g.
`js-*`
classes etc.)
or classes used by other components (
for example,
`js-*`
classes etc.)
```
ruby
```
ruby
view
'app/views/my/view.html.haml'
do
view
'app/views/my/view.html.haml'
do
...
...
doc/development/testing_guide/flaky_tests.md
View file @
85441fae
...
@@ -37,9 +37,9 @@ bin/rspec --tag quarantine
...
@@ -37,9 +37,9 @@ bin/rspec --tag quarantine
Once a test is in quarantine, there are 3 choices:
Once a test is in quarantine, there are 3 choices:
-
Should the test be fixed (
i.e.
get rid of its flakiness)?
-
Should the test be fixed (
that is,
get rid of its flakiness)?
-
Should the test be moved to a lower level of testing?
-
Should the test be moved to a lower level of testing?
-
Should the test be removed entirely (
e.g.
because there's already a
-
Should the test be removed entirely (
for example,
because there's already a
lower-level test, or it's duplicating another same-level test, or it's testing
lower-level test, or it's duplicating another same-level test, or it's testing
too much etc.)?
too much etc.)?
...
...
doc/development/windows.md
View file @
85441fae
...
@@ -136,7 +136,7 @@ PowerShell has aliases for all of the following commands so you don't have to le
...
@@ -136,7 +136,7 @@ PowerShell has aliases for all of the following commands so you don't have to le
-
`/`
--->
`\` (path separator)
-
`/`
--->
`\` (path separator)
- `
cat
` ---> `
type
`
- `
cat
` ---> `
type
`
- `
mv
` ---> `
move
`
- `
mv
` ---> `
move
`
- Redirection works the same (
i.e.
`
>
` and `
2>&1
`)
- Redirection works the same (
for example,
`
>
` and `
2>&1
`)
- `
.
\s
ome.exe
` to call a local executable
- `
.
\s
ome.exe
` to call a local executable
- curl is available
- curl is available
- `
..
` and `
.
`
are available
- `
..
` and `
.
`
are available
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment