Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
88900bc6
Commit
88900bc6
authored
Jun 25, 2020
by
Jason Goodman
Committed by
Shinya Maeda
Jun 25, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable new version feature flags for self managed instances
Default feature_flags_new_version flag to enabled
parent
87da1abf
Changes
5
Show whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
10 additions
and
5 deletions
+10
-5
ee/app/controllers/projects/feature_flags_controller.rb
ee/app/controllers/projects/feature_flags_controller.rb
+2
-2
ee/app/finders/feature_flags_finder.rb
ee/app/finders/feature_flags_finder.rb
+1
-1
ee/app/services/feature_flags/create_service.rb
ee/app/services/feature_flags/create_service.rb
+1
-1
ee/changelogs/unreleased/rollout-new-version-ff.yml
ee/changelogs/unreleased/rollout-new-version-ff.yml
+5
-0
ee/lib/api/feature_flags.rb
ee/lib/api/feature_flags.rb
+1
-1
No files found.
ee/app/controllers/projects/feature_flags_controller.rb
View file @
88900bc6
...
@@ -12,7 +12,7 @@ class Projects::FeatureFlagsController < Projects::ApplicationController
...
@@ -12,7 +12,7 @@ class Projects::FeatureFlagsController < Projects::ApplicationController
before_action
do
before_action
do
push_frontend_feature_flag
(
:feature_flag_permissions
)
push_frontend_feature_flag
(
:feature_flag_permissions
)
push_frontend_feature_flag
(
:feature_flags_new_version
,
project
)
push_frontend_feature_flag
(
:feature_flags_new_version
,
project
,
default_enabled:
true
)
end
end
def
index
def
index
...
@@ -103,7 +103,7 @@ class Projects::FeatureFlagsController < Projects::ApplicationController
...
@@ -103,7 +103,7 @@ class Projects::FeatureFlagsController < Projects::ApplicationController
end
end
def
new_version_feature_flags_enabled?
def
new_version_feature_flags_enabled?
::
Feature
.
enabled?
(
:feature_flags_new_version
,
project
)
::
Feature
.
enabled?
(
:feature_flags_new_version
,
project
,
default_enabled:
true
)
end
end
def
create_params
def
create_params
...
...
ee/app/finders/feature_flags_finder.rb
View file @
88900bc6
...
@@ -24,7 +24,7 @@ class FeatureFlagsFinder
...
@@ -24,7 +24,7 @@ class FeatureFlagsFinder
private
private
def
feature_flags
def
feature_flags
if
Feature
.
enabled?
(
:feature_flags_new_version
,
project
)
if
Feature
.
enabled?
(
:feature_flags_new_version
,
project
,
default_enabled:
true
)
project
.
operations_feature_flags
project
.
operations_feature_flags
else
else
project
.
operations_feature_flags
.
legacy_flag
project
.
operations_feature_flags
.
legacy_flag
...
...
ee/app/services/feature_flags/create_service.rb
View file @
88900bc6
...
@@ -46,7 +46,7 @@ module FeatureFlags
...
@@ -46,7 +46,7 @@ module FeatureFlags
end
end
def
new_version_feature_flags_enabled?
def
new_version_feature_flags_enabled?
::
Feature
.
enabled?
(
:feature_flags_new_version
,
project
)
::
Feature
.
enabled?
(
:feature_flags_new_version
,
project
,
default_enabled:
true
)
end
end
end
end
end
end
ee/changelogs/unreleased/rollout-new-version-ff.yml
0 → 100644
View file @
88900bc6
---
title
:
Enable new version feature flags by default
merge_request
:
35192
author
:
type
:
added
ee/lib/api/feature_flags.rb
View file @
88900bc6
...
@@ -246,7 +246,7 @@ module API
...
@@ -246,7 +246,7 @@ module API
end
end
def
feature_flags_new_version_enabled?
def
feature_flags_new_version_enabled?
Feature
.
enabled?
(
:feature_flags_new_version
,
user_project
)
Feature
.
enabled?
(
:feature_flags_new_version
,
user_project
,
default_enabled:
true
)
end
end
def
rename_key
(
hash
,
old_key
,
new_key
)
def
rename_key
(
hash
,
old_key
,
new_key
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment