Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
890fe3bd
Commit
890fe3bd
authored
Feb 18, 2020
by
Samantha Ming
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Change MR approval popover to use hover trigger
parent
bfd6f39a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
1 deletion
+7
-1
ee/app/assets/javascripts/approvals/components/empty_rule_name.vue
...sets/javascripts/approvals/components/empty_rule_name.vue
+2
-1
ee/changelogs/unreleased/38087-popover-not-showing.yml
ee/changelogs/unreleased/38087-popover-not-showing.yml
+5
-0
No files found.
ee/app/assets/javascripts/approvals/components/empty_rule_name.vue
View file @
890fe3bd
...
@@ -24,6 +24,7 @@ export default {
...
@@ -24,6 +24,7 @@ export default {
<span
id=
"popovercontainer"
class=
"ml-2 align-self-end"
>
<span
id=
"popovercontainer"
class=
"ml-2 align-self-end"
>
<icon
<icon
id=
"pop-approver"
id=
"pop-approver"
tabindex=
"0"
name=
"question-o"
name=
"question-o"
:aria-label=
"__('help')"
:aria-label=
"__('help')"
:size=
"14"
:size=
"14"
...
@@ -33,7 +34,7 @@ export default {
...
@@ -33,7 +34,7 @@ export default {
target=
"pop-approver"
target=
"pop-approver"
container=
"popovercontainer"
container=
"popovercontainer"
placement=
"top"
placement=
"top"
triggers=
"focus"
triggers=
"
hover
focus"
>
>
<template
#title
>
{{
__
(
'
Who can be an approver?
'
)
}}
</
template
>
<template
#title
>
{{
__
(
'
Who can be an approver?
'
)
}}
</
template
>
<ul
class=
"pl-3"
>
<ul
class=
"pl-3"
>
...
...
ee/changelogs/unreleased/38087-popover-not-showing.yml
0 → 100644
View file @
890fe3bd
---
title
:
Change MR approval popover to use hover trigger
merge_request
:
25494
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment