Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
8a66feff
Commit
8a66feff
authored
Mar 04, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Document the new Danger behavior
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
3e56eb9e
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
19 additions
and
0 deletions
+19
-0
doc/development/dangerbot.md
doc/development/dangerbot.md
+19
-0
No files found.
doc/development/dangerbot.md
View file @
8a66feff
...
...
@@ -13,6 +13,25 @@ If Danger is asking you to change something about your merge request, it's best
just to make the change. If you want to learn how Danger works, or make changes
to the existing rules, then this is the document for you.
## Danger comments in merge requests
As of
[
2020-03-03
](
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/26275
)
,
Danger is posting a new comment each time it runs in a pipeline and removes the
previous comments it posted. Before that, Danger would only post one comment and
update its content on subsequent
`danger-review`
runs.
### Advantages
-
You get email notifications of Danger failures before the pipeline fails.
-
If someone introduces a change that creates a new Danger warning, it's very obvious now, both in email and in the UI.
-
If there are no new Danger warnings - just the roulette message - then the email acts as confirmation of that.
-
It's easier to see if a roulette recommendation changed, which is useful for people that think about roulette logic/behavior quite often.
-
You don't have to scroll up to get to the first Danger comment (sometimes MR can have more than discussions).
### Disadvantages
-
You get new email notifications for each
`danger-review`
run, which can clutter threaded discussions in email clients.
## Run Danger locally
A subset of the current checks can be run locally with the following rake task:
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment