Merge branch 'sh-avoid-extra-route-reload' into 'master'

Speed up boot time in production

See merge request gitlab-org/gitlab!33929

changelogs/unreleased/sh-avoid-extra-route-reload.yml

+---
+title: Speed up boot time in production
+merge_request: 33929
+author:
+type: performance

config/application.rb

@@ -301,7 +301,10 @@ module Gitlab
     end
 
     config.after_initialize do
-      Rails.application.reload_routes!
+      # Devise (see initializers/8_devise.rb) already reloads routes if
+      # eager loading is enabled, so don't do this twice since it's
+      # expensive.
+      Rails.application.reload_routes! unless config.eager_load
 
       project_url_helpers = Module.new do
         extend ActiveSupport::Concern

config/initializers/8_devise.rb

@@ -6,6 +6,11 @@ Devise.setup do |config|
     manager.default_strategies(scope: :user).unshift :two_factor_backupable
   end
 
+  # This is the default. This makes it explicit that Devise loads routes
+  # before eager loading. Disabling this seems to cause an error loading
+  # grape-entity `expose` for some reason.
+  config.reload_routes = true
+
   # ==> Mailer Configuration
   # Configure the class responsible to send e-mails.
   config.mailer = "DeviseMailer"