Migrate elasticsearch-using spinach features to rspec

ee/spec/features/search/elastic/project_search_spec.rb

+require 'spec_helper'
+
+describe 'Project elastic search', :js, :elastic do
+  let(:user) { create(:user) }
+  let(:project) { create(:project, :repository, namespace: user.namespace) }
+
+  before do
+    stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
+
+    project.add_master(user)
+    sign_in(user)
+  end
+
+  describe 'searching' do
+    it 'finds issues' do
+      create(:issue, project: project, title: 'Test searching for an issue')
+
+      expect_search_result(scope: 'Issues', term: 'Test', result: 'Test searching for an issue')
+    end
+
+    it 'finds merge requests' do
+      create(:merge_request, source_project: project, target_project: project, title: 'Test searching for an MR')
+
+      expect_search_result(scope: 'Merge requests', term: 'Test', result: 'Test searching for an MR')
+    end
+
+    it 'finds milestones' do
+      create(:milestone, project: project, title: 'Test searching for a milestone')
+
+      expect_search_result(scope: 'Milestones', term: 'Test', result: 'Test searching for a milestone')
+    end
+
+    it 'finds wiki pages' do
+      project.wiki.create_page('test.md', 'Test searching for a wiki page')
+
+      expect_search_result(scope: 'Wiki', term: 'Test', result: 'Test searching for a wiki page')
+    end
+
+    it 'finds notes' do
+      create(:note, project: project, note: 'Test searching for a note')
+
+      search(scope: 'Comments', term: 'Test')
+
+      expect(page).to have_content(/showing (\d+) - (\d+) of (\d+) notes/i)
+      expect(page).to have_content('Test searching for a note')
+    end
+
+    it 'finds commits' do
+      project.repository.index_commits
+
+      search(scope: 'Commits', term: 'initial')
+
+      expect(page).to have_content(/showing (\d+) - (\d+) of (\d+) commits/i)
+      expect(page).to have_content('Initial commit')
+    end
+
+    it 'finds blobs' do
+      project.repository.index_blobs
+
+      search(scope: 'Code', term: 'def')
+
+      expect(page).to have_content(/showing (\d+) - (\d+) of (\d+) blobs/i)
+      expect(page).to have_content('def username_regex')
+    end
+  end
+
+  def search(scope:, term:)
+    visit project_path(project)
+
+    fill_in('search', with: term)
+    find('#search').native.send_keys(:enter)
+
+    page.within '.search-filter' do
+      click_link scope
+    end
+  end
+
+  def expect_search_result(scope:, term:, result:)
+    search(scope: scope, term: term)
+
+    expect(page).to have_content(/showing (\d+) - (\d+) of (\d+) #{Regexp.escape(scope)}/i)
+    expect(page).to have_content(result)
+  end
+end

ee/spec/features/search/elastic/snippet_search_spec.rb

+require 'spec_helper'
+
+describe 'Snippet elastic search', :js, :elastic do
+  let(:user) { create(:user) }
+  let(:project) { create(:project, namespace: user.namespace) }
+
+  before do
+    stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
+
+    project.add_master(user)
+    sign_in(user)
+  end
+
+  describe 'searching' do
+    it 'finds a personal snippet' do
+      create(:personal_snippet, author: user, content: 'Test searching for personal snippets')
+
+      visit explore_snippets_path
+      fill_in 'search', with: 'Test'
+      click_button 'Go'
+
+      expect(page).to have_content('Test searching for personal snippets')
+    end
+
+    it 'finds a project snippet' do
+      create(:project_snippet, project: project, content: 'Test searching for personal snippets')
+
+      visit explore_snippets_path
+      fill_in 'search', with: 'Test'
+      click_button 'Go'
+
+      expect(page).to have_content('Test searching for personal snippets')
+    end
+  end
+end

ee/spec/support/elastic.rb

+RSpec.configure do |config|
+  config.before(:each, :elastic) do
+    Gitlab::Elastic::Helper.create_empty_index
+  end
+
+  config.after(:each, :elastic) do
+    Gitlab::Elastic::Helper.delete_index
+  end
+end

features/project/elastic/global_search.feature

-Feature: Global Search
-  Background:
-    Given I sign in as a user
-    And I own project "Shop"
-    And Elasticsearch is enabled
-
-  Scenario: I search through the all projects
-    Given project has all data available for the search
-    And I visit dashboard page
-    Then I search "initial"
-    And I find an Issue
-    And I find a Merge Request
-    And I find a Milestone
\ No newline at end of file

features/project/elastic/project_search.feature

-Feature: Project Search
-  Background:
-    Given I sign in as a user
-    And I own project "Shop"
-    And Elasticsearch is enabled
-
-  Scenario: I search through the all project items
-    Given project has all data available for the search
-    And I visit my project's home page
-    Then I search "initial"
-    And I find an Issue
-    And I find a Merge Request
-    And I find a Milestone
-    And I find a Comment
-    And I find a Commit
-    And I find a Wiki Page
-    Then I visit my project's home page
-    Then I search "def"
-    And I find a Code

features/project/elastic/snippets_search.feature

-Feature: Snippets Search
-  Background:
-    Given I sign in as a user
-    And Elasticsearch is enabled
-
-  Scenario: I search through the snippets
-    Given there is a snippet "index" with "php rocks" string
-    And there is a snippet "php" with "benefits" string
-    And I visit snippets page
-    Then I search "php"
-    And I find "index" snippet
-    Then I select search by titles and filenames
-    And I find "php" snippet
\ No newline at end of file

features/steps/project/elastic/global_search.rb

-require_dependency Rails.root.join('spec', 'support', 'stub_configuration')
-
-class Spinach::Features::GlobalSearch < Spinach::FeatureSteps
-  include SharedAuthentication
-  include SharedPaths
-  include SharedProject
-  include SharedElastic
-  include StubConfiguration
-
-  before do
-    stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
-
-    Gitlab::Elastic::Helper.create_empty_index
-  end
-
-  after do
-    Gitlab::Elastic::Helper.delete_index
-
-    stub_ee_application_setting(elasticsearch_search: false, elasticsearch_indexing: false)
-  end
-
-  step 'project has all data available for the search' do
-    @project = create :project
-    @project.add_master(current_user)
-
-    @issue = create :issue, title: 'bla-bla initial', project: @project
-    @merge_request = create :merge_request, title: 'bla-bla initial', source_project: @project
-    @milestone = create :milestone, title: 'bla-bla initial', project: @project
-  end
-end

features/steps/project/elastic/project_search.rb

-class Spinach::Features::ProjectSearch < Spinach::FeatureSteps
-  include SharedAuthentication
-  include SharedPaths
-  include SharedProject
-  include SharedElastic
-  include StubConfiguration
-
-  before do
-    stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
-
-    Gitlab::Elastic::Helper.create_empty_index
-  end
-
-  after do
-    Gitlab::Elastic::Helper.delete_index
-
-    stub_ee_application_setting(elasticsearch_search: false, elasticsearch_indexing: false)
-  end
-
-  step 'project has all data available for the search' do
-    @project = create :project, :repository
-    @project.add_master(current_user)
-
-    @issue = create :issue, title: 'bla-bla initial', project: @project
-    @merge_request = create :merge_request, title: 'bla-bla initial', source_project: @project
-    @milestone = create :milestone, title: 'bla-bla initial', project: @project
-    @note = create :note, note: 'bla-bla initial', project: @project, noteable: @issue
-
-    @project.repository.index_blobs
-    @project.repository.index_commits
-
-    @project.wiki.create_page("index_page", "Bla bla initial")
-  end
-
-  step 'I search "def"' do
-    fill_in "search", with: "def"
-    click_button "Go"
-  end
-
-  step 'I find a Comment' do
-    select_filter("Comments")
-
-    expect(page.find('.search-result-row')).to have_content(@note.note)
-  end
-
-  step 'I find a Wiki Page' do
-    select_filter("Wiki")
-
-    expect(page.find('.blob-result')).to have_content('Bla bla init')
-  end
-
-  step 'I find a Commit' do
-    select_filter("Commits")
-
-    expect(page.find('.commit-content .item-title')).to have_content("Initial commit")
-  end
-
-  step 'I find a Code' do
-    expect(page.first('.blob-result')).to have_content("def")
-  end
-end

features/steps/project/elastic/snippets_search.rb

-class Spinach::Features::SnippetsSearch < Spinach::FeatureSteps
-  include SharedAuthentication
-  include SharedPaths
-  include SharedProject
-  include SharedElastic
-  include StubConfiguration
-
-  before do
-    stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
-
-    Gitlab::Elastic::Helper.create_empty_index
-  end
-
-  after do
-    Gitlab::Elastic::Helper.delete_index
-
-    stub_ee_application_setting(elasticsearch_search: false, elasticsearch_indexing: false)
-  end
-
-  step 'there is a snippet "index" with "php rocks" string' do
-    create :personal_snippet, :public, content: "php rocks", title: "index"
-    Gitlab::Elastic::Helper.refresh_index
-  end
-
-  step 'there is a snippet "php" with "benefits" string' do
-    create :personal_snippet, :public, content: "benefits", title: "php"
-    Gitlab::Elastic::Helper.refresh_index
-  end
-
-  step 'I search "php"' do
-    fill_in "search", with: "php"
-    click_button "Go"
-  end
-
-  step 'I find "index" snippet' do
-    expect(page.find('.file-holder')).to have_content("php rocks")
-  end
-
-  step 'I select search by titles and filenames' do
-    select_filter("Titles and Filenames")
-  end
-
-  step 'I find "php" snippet' do
-    expect(page.find('.search-result-row')).to have_content("php")
-  end
-end

features/steps/shared/elastic.rb

-module SharedElastic
-  include Spinach::DSL
-
-  step 'I search "initial"' do
-    fill_in "search", with: "initial"
-    click_button "Go"
-  end
-
-  step 'I find an Issue' do
-    select_filter("Issues")
-
-    expect(page.find('.search-result-row')).to have_content(@issue.title)
-  end
-
-  step 'I find a Merge Request' do
-    select_filter("Merge requests")
-
-    expect(page.find('.search-result-row')).to have_content(@merge_request.title)
-  end
-
-  step 'I find a Milestone' do
-    select_filter("Milestones")
-
-    expect(page.find('.search-result-row')).to have_content(@milestone.title)
-  end
-
-  step 'Elasticsearch is enabled' do
-    stub_ee_application_setting(elasticsearch_search: true, elasticsearch_indexing: true)
-  end
-
-  def select_filter(name)
-    find(:xpath, "//ul[contains(@class, 'search-filter')]//a[contains(.,'#{name}')]").click
-  end
-end