Merge branch 'pedropombeiro/297382/remove-leftover-project-argument' into 'master'

Remove left-over project argument

See merge request gitlab-org/gitlab!74193

app/presenters/ci/build_runner_presenter.rb

@@ -33,7 +33,7 @@ module Ci
     end
 
     def runner_variables
-      variables.sort_and_expand_all(project, keep_undefined: true).to_runner_variables
+      variables.sort_and_expand_all(keep_undefined: true).to_runner_variables
     end
 
     def refspecs

lib/gitlab/ci/pipeline/seed/build.rb

@@ -173,7 +173,7 @@ module Gitlab
           end
 
           def variable_expansion_errors
-            expanded_collection = evaluate_context.variables.sort_and_expand_all(@pipeline.project)
+            expanded_collection = evaluate_context.variables.sort_and_expand_all
             errors = expanded_collection.errors
             ["#{name}: #{errors}"] if errors
           end

lib/gitlab/ci/variables/collection.rb

@@ -89,7 +89,7 @@ module Gitlab
           end
         end
 
-        def sort_and_expand_all(project, keep_undefined: false)
+        def sort_and_expand_all(keep_undefined: false)
           sorted = Sort.new(self)
           return self.class.new(self, sorted.errors) unless sorted.valid?
 

spec/lib/gitlab/ci/variables/collection_spec.rb

@@ -358,8 +358,6 @@ RSpec.describe Gitlab::Ci::Variables::Collection do
   end
 
   describe '#sort_and_expand_all' do
-    let_it_be(:project) { create(:project) }
-
     context 'table tests' do
       using RSpec::Parameterized::TableSyntax
 
@@ -550,7 +548,7 @@ RSpec.describe Gitlab::Ci::Variables::Collection do
       with_them do
         let(:collection) { Gitlab::Ci::Variables::Collection.new(variables) }
 
-        subject { collection.sort_and_expand_all(project, keep_undefined: keep_undefined) }
+        subject { collection.sort_and_expand_all(keep_undefined: keep_undefined) }
 
         it 'returns Collection' do
           is_expected.to be_an_instance_of(Gitlab::Ci::Variables::Collection)