refactor Ci::CreatePipelineService#allowed_to_create?

9151ca7b · Maxim Rydkin · 2a54cbca · 9151ca7b
Commit 9151ca7b authored Sep 06, 2017 by Maxim Rydkin
Show whitespace changes
Inline Side-by-side

Showing with 9 additions and 9 deletions

app/services/ci/create_pipeline_service.rb app/services/ci/create_pipeline_service.rb +9 -9

No files found.
--- a/app/services/ci/create_pipeline_service.rb
+++ b/app/services/ci/create_pipeline_service.rb
@@ -96,9 +96,9 @@ module Ci
    end

    def allowed_to_create?
-      access = Gitlab::UserAccess.new(current_user, project: project)
+      return unless can?(current_user, :create_pipeline, project)

-      can?(current_user, :create_pipeline, project) &&
+      access = Gitlab::UserAccess.new(current_user, project: project)
      if branch?
        access.can_update_branch?(ref)
      elsif tag?