Merge branch '2560-approver-image' into 'master'

re-add avatar url to approver avatar

Closes #2560

See merge request !2034

app/assets/javascripts/vue_merge_request_widget/ee/components/approvals/approvals_footer.js

@@ -72,6 +72,7 @@ export default {
           <span v-for="approver in approvedBy">
             <link-to-member-avatar
               :avatarSize="20"
+              :avatar-url="approver.user.avatar_url"
               extra-link-class="approver-avatar"
               :display-name="approver.user.name"
               :profile-url="approver.user.web_url"

spec/javascripts/approvals/approvals_footer_spec.js

@@ -71,5 +71,21 @@ import ApprovalsFooter from '~/vue_merge_request_widget/ee/components/approvals/
         });
       });
     });
+
+    describe('approvers list', function () {
+      it('shows link to member avatar for for each approver', function (done) {
+        this.approvalsFooter.approvedBy.push({
+          user: {
+            avatar_url: '/dummy.jpg',
+          },
+        });
+
+        Vue.nextTick(() => {
+          const memberImage = document.querySelector('.approvers-list img');
+          expect(memberImage.src).toMatch(/dummy\.jpg$/);
+          done();
+        });
+      });
+    });
   });
 })(window.gl || (window.gl = {}));