Fixes JS error when linking to a none diff discussion in diffs

944b0478 · Phil Hughes · 8e948357 · 944b0478
Commit 944b0478 authored Jul 07, 2021 by Phil Hughes
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

app/assets/javascripts/diffs/components/app.vue app/assets/javascripts/diffs/components/app.vue +2 -2

No files found.
--- a/app/assets/javascripts/diffs/components/app.vue
+++ b/app/assets/javascripts/diffs/components/app.vue
@@ -550,8 +550,8 @@ export default {

      if (id.startsWith('#note_')) {
        const noteId = id.replace('#note_', '');
-        const discussion = this.$store.state.notes.discussions.find((d) =>
-          d.notes.find((n) => n.id === noteId),
+        const discussion = this.$store.state.notes.discussions.find(
+          (d) => d.diff_file && d.notes.find((n) => n.id === noteId),
        );

        if (discussion) {