Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
94b2f3bd
Commit
94b2f3bd
authored
May 13, 2020
by
Gilang Gumilar
Committed by
Martin Wortschack
May 13, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove project_list_show_mr_count feature flag
parent
e63b2925
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
21 deletions
+7
-21
app/helpers/projects_helper.rb
app/helpers/projects_helper.rb
+1
-1
changelogs/unreleased/214382-remove-project_list_show_mr_count-feature-flag.yml
...214382-remove-project_list_show_mr_count-feature-flag.yml
+5
-0
spec/helpers/projects_helper_spec.rb
spec/helpers/projects_helper_spec.rb
+1
-20
No files found.
app/helpers/projects_helper.rb
View file @
94b2f3bd
...
@@ -295,7 +295,7 @@ module ProjectsHelper
...
@@ -295,7 +295,7 @@ module ProjectsHelper
end
end
def
show_merge_request_count?
(
disabled:
false
,
compact_mode:
false
)
def
show_merge_request_count?
(
disabled:
false
,
compact_mode:
false
)
!
disabled
&&
!
compact_mode
&&
Feature
.
enabled?
(
:project_list_show_mr_count
,
default_enabled:
true
)
!
disabled
&&
!
compact_mode
end
end
def
show_issue_count?
(
disabled:
false
,
compact_mode:
false
)
def
show_issue_count?
(
disabled:
false
,
compact_mode:
false
)
...
...
changelogs/unreleased/214382-remove-project_list_show_mr_count-feature-flag.yml
0 → 100644
View file @
94b2f3bd
---
title
:
Remove project_list_show_mr_count feature flag.
merge_request
:
31789
author
:
Gilang Gumilar
type
:
removed
spec/helpers/projects_helper_spec.rb
View file @
94b2f3bd
...
@@ -719,11 +719,7 @@ describe ProjectsHelper do
...
@@ -719,11 +719,7 @@ describe ProjectsHelper do
end
end
describe
'#show_merge_request_count'
do
describe
'#show_merge_request_count'
do
context
'when the feature flag is enabled'
do
context
'enabled flag'
do
before
do
stub_feature_flags
(
project_list_show_mr_count:
true
)
end
it
'returns true if compact mode is disabled'
do
it
'returns true if compact mode is disabled'
do
expect
(
helper
.
show_merge_request_count?
).
to
be_truthy
expect
(
helper
.
show_merge_request_count?
).
to
be_truthy
end
end
...
@@ -733,22 +729,7 @@ describe ProjectsHelper do
...
@@ -733,22 +729,7 @@ describe ProjectsHelper do
end
end
end
end
context
'when the feature flag is disabled'
do
before
do
stub_feature_flags
(
project_list_show_mr_count:
false
)
end
it
'always returns false'
do
expect
(
helper
.
show_merge_request_count?
(
disabled:
false
)).
to
be_falsy
expect
(
helper
.
show_merge_request_count?
(
disabled:
true
)).
to
be_falsy
end
end
context
'disabled flag'
do
context
'disabled flag'
do
before
do
stub_feature_flags
(
project_list_show_mr_count:
true
)
end
it
'returns false if disabled flag is true'
do
it
'returns false if disabled flag is true'
do
expect
(
helper
.
show_merge_request_count?
(
disabled:
true
)).
to
be_falsey
expect
(
helper
.
show_merge_request_count?
(
disabled:
true
)).
to
be_falsey
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment