Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
97094154
Commit
97094154
authored
Feb 04, 2020
by
Natalia Tepluhina
Committed by
Martin Wortschack
Feb 04, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Design discussion note preview is broken"
parent
43a868d8
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
13 additions
and
1 deletion
+13
-1
app/assets/javascripts/vue_shared/components/markdown/field.vue
...sets/javascripts/vue_shared/components/markdown/field.vue
+7
-1
changelogs/unreleased/201761-design-discussion-note-preview-is-broken.yml
...eased/201761-design-discussion-note-preview-is-broken.yml
+5
-0
ee/app/assets/javascripts/design_management/components/design_notes/design_reply_form.vue
..._management/components/design_notes/design_reply_form.vue
+1
-0
No files found.
app/assets/javascripts/vue_shared/components/markdown/field.vue
View file @
97094154
...
...
@@ -79,6 +79,12 @@ export default {
required
:
false
,
default
:
false
,
},
// This prop is used as a fallback in case if textarea.elm is undefined
textareaValue
:
{
type
:
String
,
required
:
false
,
default
:
''
,
},
},
data
()
{
return
{
...
...
@@ -183,7 +189,7 @@ export default {
Can't use `$refs` as the component is technically in the parent component
so we access the VNode & then get the element
*/
const
text
=
this
.
$slots
.
textarea
[
0
]
.
elm
.
v
alue
;
const
text
=
this
.
$slots
.
textarea
[
0
]
?.
elm
?.
value
||
this
.
textareaV
alue
;
if
(
text
)
{
this
.
markdownPreviewLoading
=
true
;
...
...
changelogs/unreleased/201761-design-discussion-note-preview-is-broken.yml
0 → 100644
View file @
97094154
---
title
:
Resolve Design discussion note preview is broken
merge_request
:
24288
author
:
type
:
fixed
ee/app/assets/javascripts/design_management/components/design_notes/design_reply_form.vue
View file @
97094154
...
...
@@ -53,6 +53,7 @@ export default {
:markdown-preview-path=
"markdownPreviewPath"
:can-attach-file=
"false"
:enable-autocomplete=
"false"
:textarea-value=
"value"
markdown-docs-path=
"/help/user/markdown"
class=
"bordered-box"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment