Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
98ef2fa1
Commit
98ef2fa1
authored
Apr 16, 2020
by
Jose Vargas
Committed by
Dhiraj Bodicherla
Apr 30, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove metrics_dashboard_visibility_switching_available ff
parent
ee24d05f
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
6 additions
and
14 deletions
+6
-14
app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
...projects/shared/permissions/components/settings_panel.vue
+1
-7
app/controllers/projects_controller.rb
app/controllers/projects_controller.rb
+0
-4
changelogs/unreleased/jivanvl-remove-feature-flag-visibility-toggle-monitoring.yml
...anvl-remove-feature-flag-visibility-toggle-monitoring.yml
+5
-0
spec/frontend/pages/projects/shared/permissions/components/settings_panel_spec.js
...ects/shared/permissions/components/settings_panel_spec.js
+0
-3
No files found.
app/assets/javascripts/pages/projects/shared/permissions/components/settings_panel.vue
View file @
98ef2fa1
...
@@ -3,7 +3,6 @@ import { GlSprintf, GlLink } from '@gitlab/ui';
...
@@ -3,7 +3,6 @@ import { GlSprintf, GlLink } from '@gitlab/ui';
import
settingsMixin
from
'
ee_else_ce/pages/projects/shared/permissions/mixins/settings_pannel_mixin
'
;
import
settingsMixin
from
'
ee_else_ce/pages/projects/shared/permissions/mixins/settings_pannel_mixin
'
;
import
{
s__
}
from
'
~/locale
'
;
import
{
s__
}
from
'
~/locale
'
;
import
glFeatureFlagsMixin
from
'
~/vue_shared/mixins/gl_feature_flags_mixin
'
;
import
projectFeatureSetting
from
'
./project_feature_setting.vue
'
;
import
projectFeatureSetting
from
'
./project_feature_setting.vue
'
;
import
projectFeatureToggle
from
'
~/vue_shared/components/toggle_button.vue
'
;
import
projectFeatureToggle
from
'
~/vue_shared/components/toggle_button.vue
'
;
import
projectSettingRow
from
'
./project_setting_row.vue
'
;
import
projectSettingRow
from
'
./project_setting_row.vue
'
;
...
@@ -26,7 +25,7 @@ export default {
...
@@ -26,7 +25,7 @@ export default {
GlSprintf
,
GlSprintf
,
GlLink
,
GlLink
,
},
},
mixins
:
[
settingsMixin
,
glFeatureFlagsMixin
()
],
mixins
:
[
settingsMixin
],
props
:
{
props
:
{
currentSettings
:
{
currentSettings
:
{
...
@@ -200,10 +199,6 @@ export default {
...
@@ -200,10 +199,6 @@ export default {
'
ProjectSettings|View and edit files in this project. Non-project members will only have read access
'
,
'
ProjectSettings|View and edit files in this project. Non-project members will only have read access
'
,
);
);
},
},
metricsDashboardVisibilitySwitchingAvailable
()
{
return
this
.
glFeatures
.
metricsDashboardVisibilitySwitchingAvailable
;
},
},
},
watch
:
{
watch
:
{
...
@@ -480,7 +475,6 @@ export default {
...
@@ -480,7 +475,6 @@ export default {
/>
/>
</project-setting-row>
</project-setting-row>
<project-setting-row
<project-setting-row
v-if=
"metricsDashboardVisibilitySwitchingAvailable"
ref=
"metrics-visibility-settings"
ref=
"metrics-visibility-settings"
:label=
"__('Metrics Dashboard')"
:label=
"__('Metrics Dashboard')"
:help-text=
"
:help-text=
"
...
...
app/controllers/projects_controller.rb
View file @
98ef2fa1
...
@@ -36,10 +36,6 @@ class ProjectsController < Projects::ApplicationController
...
@@ -36,10 +36,6 @@ class ProjectsController < Projects::ApplicationController
layout
:determine_layout
layout
:determine_layout
before_action
do
push_frontend_feature_flag
(
:metrics_dashboard_visibility_switching_available
)
end
def
index
def
index
redirect_to
(
current_user
?
root_path
:
explore_root_path
)
redirect_to
(
current_user
?
root_path
:
explore_root_path
)
end
end
...
...
changelogs/unreleased/jivanvl-remove-feature-flag-visibility-toggle-monitoring.yml
0 → 100644
View file @
98ef2fa1
---
title
:
Add metric dashboard public visibility toggle
merge_request
:
29718
author
:
type
:
added
spec/frontend/pages/projects/shared/permissions/components/settings_panel_spec.js
View file @
98ef2fa1
...
@@ -57,9 +57,6 @@ describe('Settings Panel', () => {
...
@@ -57,9 +57,6 @@ describe('Settings Panel', () => {
return
mountFn
(
settingsPanel
,
{
return
mountFn
(
settingsPanel
,
{
propsData
,
propsData
,
provide
:
{
glFeatures
:
{
metricsDashboardVisibilitySwitchingAvailable
:
true
},
},
});
});
};
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment