Commit 98f898d3 authored by Ramya Authappan's avatar Ramya Authappan

Merge branch 'qa/improve-performance-of-login-test-and-remove-comments' into 'master'

Improve performance of login test and remove comments

See merge request gitlab-org/gitlab-ce!27515
parents 10bf3bbc 2fba2ade
...@@ -7,16 +7,12 @@ module QA ...@@ -7,16 +7,12 @@ module QA
Runtime::Browser.visit(:gitlab, Page::Main::Login) Runtime::Browser.visit(:gitlab, Page::Main::Login)
Page::Main::Login.act { sign_in_using_credentials } Page::Main::Login.act { sign_in_using_credentials }
# TODO, since `Signed in successfully` message was removed
# this is the only way to tell if user is signed in correctly.
#
Page::Main::Menu.perform do |menu| Page::Main::Menu.perform do |menu|
expect(menu).to have_personal_area expect(menu).to have_personal_area
end end
Page::Main::Menu.perform do |menu| Page::Main::Menu.perform do |menu|
menu.sign_out menu.sign_out
expect(menu).not_to have_personal_area
end end
Page::Main::Login.perform do |form| Page::Main::Login.perform do |form|
......
...@@ -7,9 +7,6 @@ module QA ...@@ -7,9 +7,6 @@ module QA
Runtime::Browser.visit(:gitlab, Page::Main::Login) Runtime::Browser.visit(:gitlab, Page::Main::Login)
Page::Main::Login.act { sign_in_using_credentials } Page::Main::Login.act { sign_in_using_credentials }
# TODO, since `Signed in successfully` message was removed
# this is the only way to tell if user is signed in correctly.
#
Page::Main::Menu.perform do |menu| Page::Main::Menu.perform do |menu|
expect(menu).to have_personal_area expect(menu).to have_personal_area
end end
......
...@@ -7,9 +7,6 @@ module QA ...@@ -7,9 +7,6 @@ module QA
Resource::User.fabricate_via_browser_ui! Resource::User.fabricate_via_browser_ui!
# TODO, since `Signed in successfully` message was removed
# this is the only way to tell if user is signed in correctly.
#
Page::Main::Menu.perform do |menu| Page::Main::Menu.perform do |menu|
expect(menu).to have_personal_area expect(menu).to have_personal_area
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment